fix(a11y): fixed background contrast in Lighthouse#8103
Open
pranjalisr wants to merge 1 commit intowebpack:mainfrom
Open
fix(a11y): fixed background contrast in Lighthouse#8103pranjalisr wants to merge 1 commit intowebpack:mainfrom
pranjalisr wants to merge 1 commit intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
@evenstensberg please take a look |
Member
|
This is good, but again, is there a way to preserve a11y while not having underlined links? It doesnt look good. |
Contributor
Author
Underline is there in main website(main code) of webpack. But if you suggest not having it then I will remove underline from main and push code changes here. |
Member
|
Unfortunate, thats a mistake in reviewing on us. Can you remove the underline? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed Background and foreground colors do not have sufficient contrast ratio under Contrast issue in Lighthouse
Before
After
What kind of change does this PR introduce?
Code change
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
N/A
Use of AI
Copilot