fix: prevent args to the task being consumed by vp#286
Merged
branchseer merged 5 commits intovoidzero-dev:mainfrom Mar 23, 2026
Merged
fix: prevent args to the task being consumed by vp#286branchseer merged 5 commits intovoidzero-dev:mainfrom
branchseer merged 5 commits intovoidzero-dev:mainfrom
Conversation
Contributor
Author
|
@codex should I use |
|
You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard. |
Member
|
Thanks! |
fengmk2
added a commit
to voidzero-dev/vite-plus
that referenced
this pull request
Mar 27, 2026
…hange vite-task PR voidzero-dev/vite-task#286 and voidzero-dev/vite-task#290 changed trailing_var_arg to the command level, meaning flags like `-r` must now appear before the task name. Tokens after the task name are passed through verbatim to the task process. - `vp run -r test` (correct) — `-r` is the recursive flag - `vp run test -r` (broken) — `-r` is passed through to the task Add snap test `command-run-argument-order` verifying both behaviors. Update monorepo template, docs, and RFCs to use the new syntax.
fengmk2
added a commit
to voidzero-dev/vite-plus
that referenced
this pull request
Mar 27, 2026
…hange vite-task PR voidzero-dev/vite-task#286 and voidzero-dev/vite-task#290 changed trailing_var_arg to the command level, meaning flags like `-r` must now appear before the task name. Tokens after the task name are passed through verbatim to the task process. - `vp run -r test` (correct) — `-r` is the recursive flag - `vp run test -r` (broken) — `-r` is passed through to the task Add snap test `command-run-argument-order` verifying both behaviors. Update monorepo template, docs, and RFCs to use the new syntax.
fengmk2
added a commit
to voidzero-dev/vite-plus
that referenced
this pull request
Mar 27, 2026
…hange (#1170) vite-task PR voidzero-dev/vite-task#286 and voidzero-dev/vite-task#290 changed trailing_var_arg to the command level, meaning flags like `-r` must now appear before the task name. Tokens after the task name are passed through verbatim to the task process. - `vp run -r test` (correct) — `-r` is the recursive flag - `vp run test -r` (broken) — `-r` is passed through to the task Add snap test `command-run-argument-order` verifying both behaviors. Update monorepo template, docs, and RFCs to use the new syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #285
This PR merged
task_specifierandadditional_argsintotask_and_argsfield to ensure args after the task name to be directly passed to the task itself instead of Vite task.