fix!: update vp run argument order for flags-before-task breaking change#1170
Merged
fix!: update vp run argument order for flags-before-task breaking change#1170
vp run argument order for flags-before-task breaking change#1170Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
…hange vite-task PR voidzero-dev/vite-task#286 and voidzero-dev/vite-task#290 changed trailing_var_arg to the command level, meaning flags like `-r` must now appear before the task name. Tokens after the task name are passed through verbatim to the task process. - `vp run -r test` (correct) — `-r` is the recursive flag - `vp run test -r` (broken) — `-r` is passed through to the task Add snap test `command-run-argument-order` verifying both behaviors. Update monorepo template, docs, and RFCs to use the new syntax.
fengmk2
force-pushed
the
vite-task-argument-breaking
branch
from
d6f0c70 to
e812aa6
Compare
Member
Author
|
rfcs/run-without-vite-plus-dependency.md this fallback feature will be removed in next pr. |
branchseer
approved these changes
Mar 27, 2026
Member
Author
|
@cpojer Just a heads up, the next version has an incompatible update to parameters. I think this update is very necessary to avoid confusion with the actual task command parameters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vite-task PR voidzero-dev/vite-task#286 and
voidzero-dev/vite-task#290 changed trailing_var_arg
to the command level, meaning flags like
-rmust now appear before thetask name. Tokens after the task name are passed through verbatim to the
task process.
vp run -r test(correct) —-ris the recursive flagvp run test -r(broken) —-ris passed through to the taskAdd snap test
command-run-argument-orderverifying both behaviors.Update monorepo template, docs, and RFCs to use the new syntax.