fix(migrate): auto-remove allowSyntheticDefaultImports: false from tsconfig.json#1153
Draft
fengmk2 wants to merge 1 commit intoauto-remove-esModuleInterop-false-on-migratefrom
Conversation
8 tasks
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
…config.json Same deprecation reason as esModuleInterop: false — tsgolint no longer supports these options set to false. Generalize the removal into a reusable `removeDeprecatedTsconfigFalseOption` function and apply it to both options during migration. See oxc-project/tsgolint#351
fengmk2
force-pushed
the
auto-remove-esModuleInterop-false-on-migrate
branch
from
2f47f2d to
e94c039
Compare
fengmk2
force-pushed
the
auto-remove-allowSyntheticDefaultImports-false
branch
from
8a893f2 to
8dff00e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same deprecation reason as esModuleInterop: false — tsgolint no longer
supports these options set to false. Generalize the removal into a
reusable
removeDeprecatedTsconfigFalseOptionfunction and apply itto both options during migration.
See #1145