fix(migrate): auto-remove esModuleInterop: false from tsconfig.json#1148
Draft
fix(migrate): auto-remove esModuleInterop: false from tsconfig.json#1148
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
fengmk2
force-pushed
the
auto-remove-esModuleInterop-false-on-migrate
branch
2 times, most recently
from
2630654 to
64c3b45
Compare
Closes #1145 When `vp migrate` runs, it now scans all tsconfig*.json files and removes `"esModuleInterop": false` which has been deprecated by oxlint's tsgolint and causes lint errors with type-aware checking. Uses jsonc-parser for JSONC-aware editing that correctly handles inline comments, compact formatting, and trailing commas. Moved jsonc-parser to dependencies temporarily until bundle refactoring lands (#744).
Cover inline block comments, compact single-line JSON, compact single-line JSONC, and last-property trailing comma. Use inline snapshots to verify complete output correctness.
fengmk2
force-pushed
the
auto-remove-esModuleInterop-false-on-migrate
branch
from
64c3b45 to
1e072a4
Compare
fengmk2
commented
Mar 26, 2026
camc314
reviewed
Mar 26, 2026
rfcs/migration-command.md
Outdated
Comment on lines
+614
to
+621
| - `"esModuleInterop": false` — This option has been removed by oxlint's tsgolint. When present, `vp lint --type-aware` fails with: `Option 'esModuleInterop=false' has been removed.` | ||
|
|
||
| **Behavior**: | ||
|
|
||
| - Only `esModuleInterop: false` is removed — `true` is left alone | ||
| - Uses `jsonc-parser` for JSONC-aware editing that preserves comments and formatting | ||
| - Scans all `tsconfig*.json` variants (e.g., `tsconfig.json`, `tsconfig.app.json`, `tsconfig.node.json`) | ||
| - Runs automatically as part of the config rewrite phase — no user prompt needed |
Contributor
There was a problem hiding this comment.
Maybe rephrase this?
- oxlint's tsgolint hasn't remove it, typescript has?
Member
Author
There was a problem hiding this comment.
"esModuleInterop": false — This option has been removed by typescript. When present, vp lint --type-aware fails with: Option 'esModuleInterop=false' has been removed.
fengmk2
force-pushed
the
auto-remove-esModuleInterop-false-on-migrate
branch
from
6734bd2 to
2f47f2d
Compare
Co-authored-by: Cameron <cameron.clark@hey.com> Signed-off-by: MK (fengmk2) <fengmk2@gmail.com>
fengmk2
force-pushed
the
auto-remove-esModuleInterop-false-on-migrate
branch
from
2f47f2d to
e94c039
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1145
When
vp migrateruns, it now scans all tsconfig*.json files andremoves
"esModuleInterop": falsewhich has been deprecated byoxlint's tsgolint and causes lint errors with type-aware checking.