Skip to content

Improve project detail expansion performance #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wahahaha-hub wants to merge 1 commit into from
+7 −1
Closed

Improve project detail expansion performance #3221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions website/static/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ rows.forEach(function (row, i) {
next = next.nextElementSibling;
}
row._expandRow = next;
if (row._descRow) {
row.classList.toggle("has-visible-desc", !row._descRow.hidden);
}
});

function collapseAll() {
Expand Down Expand Up @@ -165,6 +168,7 @@ function applyFilters() {
if (row._descRow.hidden !== descHidden) {
row._descRow.hidden = descHidden;
}
row.classList.toggle("has-visible-desc", !descHidden);
}

if (show) {
Expand Down
4 changes: 3 additions & 1 deletion website/static/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@ kbd {
box-shadow: inset 3px 0 0 var(--accent);
}

.row:has(+ .desc-row:not([hidden])) td {
.row.has-visible-desc td {
border-bottom-color: transparent;
padding-bottom: 0.35rem;
}
Expand Down Expand Up @@ -1000,7 +1000,9 @@ th[data-sort].sort-asc::after {
text-wrap: pretty;
overflow-wrap: break-word;
word-break: break-word;
content-visibility: auto;
contain: layout style paint;
contain-intrinsic-size: auto 5rem;
animation: expand-in 220ms cubic-bezier(0.22, 1, 0.36, 1);
}

Expand Down