Improve project detail expansion performance#3221
Closed
wahahaha-hub wants to merge 1 commit into
Closed
Conversation
Owner
|
@wahahaha-hub Thanks for your PR! However, the way it expands is actually intentional, so that readers can select and compare different libraries. |
981650b to
6095304
Compare
Author
|
Thanks for the feedback. After testing a revised version that preserves the inline comparison behavior, I don't think the performance improvement is strong enough to justify the change. I'll close this PR for now and revisit this with a better approach if I find one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR replaces the inline project detail expansion with a fixed detail panel.
Problem
The previous inline expansion inserted detail content directly into the table flow.
On large tables, expanding rows near the top could cause noticeable lag because the browser had to recalculate layout for many following rows. This was especially visible when interacting with early rows in the list.
Why This Approach
The new fixed detail panel avoids changing the table height when a project is opened.
This reduces layout work while preserving the same project detail content and keeping the main table visually stable.
Interaction And Accessibility
aria-expanded,aria-controls, andaria-labelledbyare updated for the panel interaction.Responsive Behavior
Validation
uv run python website/build.pyuv run pytest website/tests/ -vuv run ruff check .