Repository navigation
Add a setting that says a new Bluetooth volume as loud as the speech after it - #460
Open
nibarAhmed wants to merge 5 commits into
Open
nibarAhmed wants to merge 5 commits into
nibarAhmed wants to merge 5 commits into
Conversation
TalkBack waited until the volume keys had been still for 2 seconds, and didn't say the media volume while media played. Backtalk now says each new level right away, says a held key's level when it's released, keeps changes that aren't the user's quiet, such as the level headphones bring when they connect, and nudges the accessibility volume on Bluetooth so the announcement plays at the new level. "Backtalk off" is said at the accessibility volume on Samsung phones and on each output. Fixes trypsynth#295 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…after it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #451. This branch builds on it, so until #451 is in, the diff here includes its changes too; only the last commit, "Add a setting that says a new Bluetooth volume as loud as the speech after it", is new. Once #451 merges I'll rebase this onto
master.On Bluetooth headphones that control their own volume, Android raises speech to make up for the media volume, but only works out how much when speech starts or the accessibility volume changes. So a new media volume said over speech that's still playing keeps the old level, and sounds louder or quieter than the speech after it.
This is split out of #451, as asked there, because it briefly changes the user's accessibility volume, so it's behind a new switch that's off by default: Verbosity > Match volume announcements to speech on Bluetooth (experimental). With it on:
With it off, nothing changes from #451.
differences.mddescribes the switch.Testing
QuietBeforeAnnouncementTest).Created with Claude Opus 5.5 in Claude Code, through T3 Code. Reviews by Claude Sonnet 5.5 subagents.
🤖 Generated with Claude Code