Repository navigation
Say the volume as soon as it changes - #451
nibarAhmed wants to merge 5 commits into
Conversation
5ca1252 to
8979dc2
Compare
|
Thanks, this is laid out well: the volume code is in files of its own, and Google's files only get small hooks. It's still three changes in one, though, and I'd like to take them one at a time:
I'm least sure about 3. It briefly changes the user's volume on every announcement, and I'd want it tried on more than one phone and pair of headphones before it goes in. Could you split this so that 1 is here and 2 and 3 come after it? |
|
Note 🤖 Claude Opus 5.5 responding on behalf of nibarAhmed I can split out 3, but I'd like to keep 1 and 2 together. On its own, 1 makes connecting headphones worse than it is now. When headphones connect, Android switches the media level to theirs and sends a volume change for it. Today that change is said 2 seconds later, and not at all while music plays, because 3, the Bluetooth nudge, can come apart into a PR of its own. Without it nothing breaks; announcements on Bluetooth can just be a little louder or quieter than the speech after them, as before. I can put it behind a setting that's off by default, so it can be tried on more phones and headphones before anyone gets it. The "Backtalk off" fix in Since opening this, another user has tested the change as well. Does that work for you? If so, this PR keeps 1 and 2, and I'll open 3 after it. |
|
That makes sense. You're right that 1 alone would announce the headphones' level mid-song, so keep 1 and 2 together. Please move 3 into its own PR, off by default as you suggest, and take with it whatever in |
TalkBack waited until the volume keys had been still for 2 seconds, and didn't say the media volume while media played. Backtalk now says each new level right away, says a held key's level when it's released, keeps changes that aren't the user's quiet, such as the level headphones bring when they connect, and nudges the accessibility volume on Bluetooth so the announcement plays at the new level. "Backtalk off" is said at the accessibility volume on Samsung phones and on each output. Fixes trypsynth#295 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
79fa46e to
9792f2f
Compare
|
Note 🤖 Claude Opus 5.5 responding on behalf of nibarAhmed Done: the Bluetooth nudge is now in #460, behind Verbosity > Steady volume announcements on Bluetooth, off by default.
#460 builds on this branch, so it should merge after this one; I'll rebase it onto |
|
Thanks for splitting it. This reads well, and the shape is right. A few things before it goes in:
Smaller, if you have time: |
…evel quiet Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note 🤖 Claude Opus 5.5 responding on behalf of nibarAhmed Points 2 and 3, question 4 and both smaller items are fixed in 193a34b. Point 1 is left as it is, because master doesn't say a press at the limit either. Latest master is merged in (d0ec992). 1. A press at the limit (not changed). Android doesn't send a volume broadcast for a press that can't change the level. That means the
I tried saying the level again when a key is released at the limit soon after a change. It needed a guess about which stream the key would change, it stayed silent after a pause anyway, and it didn't fire reliably on the emulator, so I dropped it. If you want a press at the limit to give feedback, that would be a new feature, best done separately. 2. Mute.
3. Listener first. 4. Accessibility per output. Yes. Each output keeps its own accessibility level, so connecting headphones would have said theirs.
|
|
Tested and works on the galaxy S24 Ultra. |
TalkBack waited until the volume keys had been still for 2 seconds before saying the volume, and it didn't say the media volume while media played. That made the volume keys feel slow. Connecting headphones could also make Backtalk read out the level they brought with them.
Now Backtalk says the new volume as soon as it changes:
The volume code moved out of Google's
VolumeMonitorintoVolumeAnnouncer, so Google's Java files only get small hooks.differences.mddescribes the new behaviour.Fixes #295. The issue's optional sound cues instead of speech are left out. Making a new volume on Bluetooth headphones as loud as the speech after it is in #460, which builds on this one.
Testing
VolumeMonitorTest,FinalAnnouncementVolumeTest).Created with Claude Opus 5.5 in Claude Code, through T3 Code.
🤖 Generated with Claude Code