Align network connection doc with libp2p and java-tron source code#598
Open
abn2357 wants to merge 2 commits into
Open
Align network connection doc with libp2p and java-tron source code#598abn2357 wants to merge 2 commits into
abn2357 wants to merge 2 commits into
Conversation
- enironments -> environments - HTTP port 16887 -> 8090 in connecting_to_tron and private_network - Genesis block timestamp comment now matches java-tron config.conf - Expand Number of Node Connections to cover minConnections, minActiveConnections, maxConnectionsWithSameIp and trust-peer behavior
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed
docs/using_javatron/connecting_to_tron.mdagainst the libp2p source and java-tronconfig.conf, and corrected several inaccuracies.minConnections,minActiveConnections, andmaxConnectionsWithSameIp(previously onlymaxConnectionswas documented). The new wording reflects how the parameters actually interact inlibp2p'sConnPoolServiceandChannelManager: trust-peer handling, that outbound bypassesmaxConnections, and the startup clamping done inTronNetService.16887to8090, the actual defaultnode.http.fullNodePortinconfig.conf. Applied in bothconnecting_to_tron.mdandprivate_network.md.config.conf(# Genesis block timestamp, milli seconds), removing the misleading#2017-8-26 12:00:00annotation next to a literal"0".enironments→environments.Test plan
curlexamples (getnodeinfo,getnowblock) work against a local java-tron fullnode using port 8090.