Align network connection doc with libp2p and java-tron source#327
Open
abn2357 wants to merge 1 commit into
Open
Align network connection doc with libp2p and java-tron source#327abn2357 wants to merge 1 commit into
abn2357 wants to merge 1 commit into
Conversation
- Expand "节点连接数量" to cover minConnections, minActiveConnections, and maxConnectionsWithSameIp, reflecting how the parameters interact in libp2p's ConnPoolService and ChannelManager. - Correct the HTTP port in API examples from 16887 to 8090, the actual default node.http.fullNodePort. Applied in both connecting_to_tron.md and private_network.md. - Update the genesis block timestamp comment to match java-tron's config.conf wording.
vivian1912
reviewed
May 18, 2026
|
|
||
| ``` | ||
| $ curl http://127.0.0.1:16887/wallet/getnodeinfo | ||
| $ curl http://127.0.0.1:8090/wallet/getnodeinfo |
Contributor
There was a problem hiding this comment.
Minor: the curl example for getnodeinfo has a leading $ prefix while the getnowblock example below does not. For consistency, it would be good to standardize across all shell snippets — suggest dropping the $ from all shell snippets — this makes them easier to copy and paste directly. Maybe we can address this in a separate cleanup PR to keep this one focused.
Contributor
Author
There was a problem hiding this comment.
Good Suggestion. I will start a new pr to solve such problems across all docs later.
vivian1912
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed
docs/using_javatron/connecting_to_tron.mdagainst the libp2p source and java-tronconfig.conf, and corrected several inaccuracies. Mirrors tronprotocol/documentation-en#598.minConnections,minActiveConnections, andmaxConnectionsWithSameIp(previously onlymaxConnectionswas documented). The new wording reflects how the parameters actually interact inlibp2p'sConnPoolServiceandChannelManager: trust-peer handling, that outbound bypassesmaxConnections, and the startup clamping done inTronNetService.16887to8090, the actual defaultnode.http.fullNodePortinconfig.conf. Applied in bothconnecting_to_tron.mdandprivate_network.md.config.conf(# Genesis block timestamp, milli seconds), removing the misleading#2017-8-26 12:00:00annotation next to a literal"0".Test plan
curlexamples (getnodeinfo,getnowblock) work against a local java-tron fullnode using port 8090.