Skip to content

fix: use direct path value in envoy instead of query params #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveiliop56 merged 2 commits into from
Oct 5, 2026
Merged

fix: use direct path value in envoy instead of query params #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20290ee
fix: use direct path value in envoy instead of query params
steveiliop56 Oct 4, 2026
aa2053f
tests: fix tests
steveiliop56 Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/controller/proxy_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@ func (controller *ProxyController) getExtAuthzContext(c *gin.Context) (ProxyCont
return ProxyContext{}, errors.New("host not found")
}

// We get the path from the query string
path := c.Query("path")
// The path is attached to the end of the /api/auth/envoy?path= string so we just strip it out
path := strings.TrimPrefix(c.Request.RequestURI, "/api/auth/envoy?path=")

if strings.TrimSpace(path) == "" {
return ProxyContext{}, errors.New("path not found")
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Expand Down
23 changes: 11 additions & 12 deletions internal/controller/proxy_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func TestProxyController(t *testing.T) {
router.ServeHTTP(recorder, req)
assert.Equal(t, http.StatusFound, recorder.Code)
location := recorder.Header().Get("Location")
assert.Contains(t, location, url.QueryEscape("https://test.example.com/hello?foo=bar"))
assert.Contains(t, location, url.QueryEscape("https://test.example.com%2Fhello%3Ffoo%3Dbar"))
assert.Contains(t, location, "login_for=app")
assert.Contains(t, location, "https://tinyauth.example.com/login")
},
Expand Down Expand Up @@ -464,17 +464,6 @@ func TestProxyController(t *testing.T) {
assert.Equal(t, http.StatusBadRequest, recorder.Code)
},
},
{
description: "Ensure path block ACL cannot be bypassed with query params on envoy ext authz",
middlewares: []gin.HandlerFunc{},
run: func(t *testing.T, router *gin.Engine, recorder *httptest.ResponseRecorder) {
req := httptest.NewRequest("HEAD", "/api/auth/envoy?path=/admin%3Ffoo=bar", nil)
req.Host = "path-block.example.com"
req.Header.Set("x-forwarded-proto", "https")
router.ServeHTTP(recorder, req)
assert.Equal(t, http.StatusUnauthorized, recorder.Code)
},
},
{
description: "Ensure path block ACL cannot be bypassed with dot segments on nginx auth request",
middlewares: []gin.HandlerFunc{},
Expand Down Expand Up @@ -903,6 +892,16 @@ func TestProxyController(t *testing.T) {
assert.Equal(t, http.StatusBadRequest, recorder.Code)
},
},
{
description: "Ext authz path should not be treated as a query parameter",
run: func(t *testing.T, router *gin.Engine, recorder *httptest.ResponseRecorder) {
req := httptest.NewRequest("HEAD", "/api/auth/envoy?path=/admin?;&path=/allowed", nil)
req.Host = "path-allow.example.com"
req.Header.Set("x-forwarded-proto", "https")
router.ServeHTTP(recorder, req)
assert.Equal(t, http.StatusUnauthorized, recorder.Code)
},
},
}

store := memory.New()
Expand Down
Loading