Refactor loader functions to improve error handling and simplify response structure in package source tab

[Oksamies]

No description provided.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 11-19-refactor_loader_functions_to_improve_error_handling_and_simplify_response_structure_in_package_source_tab

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Oksamies]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Refactor loader functions to improve error handling and simplify response structure in package source tab #1617 👈 (View in Graphite)
• (ts-api-react-actions) Enhance error handling in API actions and hooks with user-facing error mapping #1616 : 18 other dependent PRs (#1618 , #1619 , #1620 and 15 others)
• Refactor API methods to remove unnecessary async/await and improve return handling #1615
• (thunderstore-api) Implement user-facing error handling improvements and update tests for authentication errors #1614
• Implement Nimbus error handling components and utilities for consistent user-facing error messages #1613
• chore: migrate build system to Vite and update TS config #1648
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[anttimaki]

1. Nitpick: this could be defined as variable outside the loader and then used by both loaders.
2. Offtopic: packageListing.tsx seems to always render link to this tab even if the source doesn't exists. Not ideal UX and not up to feature parity
3. On the legacy site accessing source tab for a mod that doesn't have source available doesn't show 404. I personally think showing 404 here would be ok if we didn't link to the non-existent page ourselves. If Add ESLint #2 above isn't fixed, I think this page should show non-404 page that tells the user the source isn't available. I don't have a strong opinion on which one we do, but we should do one.

[anttimaki]

I think I didn't get any response the last time I suggested using export { NimbusDefaultRouteErrorBoundary as ErrorBoundary } from "cyberstorm/utils/errors/NimbusErrorBoundary";. Does that not work or do you think it's a bad idea otherwise?