(ts-api-react-actions) Enhance error handling in API actions and hooks with user-facing error mapping #1616

Oksamies · 2025-11-19T12:41:14Z

(ts-api-react-actions) Enhance error handling in API actions and hooks with user-facing error mapping

Refactor loader functions to enhance error handling and move to different file

Enhance error handling in StrongForm and useFormToaster with user-facing error mapping

coderabbitai · 2025-11-19T12:41:20Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Oksamies · 2025-11-19T12:41:33Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

(ts-api-react-actions) Enhance error handling in API actions and hooks with user-facing error mapping #1616 : 19 dependent PRs (#1617 , #1618 , #1619 and 16 others) 👈 (View in Graphite)
Refactor API methods to remove unnecessary async/await and improve return handling #1615
(thunderstore-api) Implement user-facing error handling improvements and update tests for authentication errors #1614
Implement Nimbus error handling components and utilities for consistent user-facing error messages #1613
chore: migrate build system to Vite and update TS config #1648
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

anttimaki · 2025-11-28T12:04:51Z

packages/ts-api-react-actions/src/ApiAction.tsx

 import { useApiAction } from "./useApiAction";

+/**
+ * Props for the `ApiAction` component that exposes an async submit handler.


Nitpick: low value comment

anttimaki · 2025-11-28T12:09:30Z

packages/ts-api-react-actions/src/ApiAction.tsx

+ * Props for the `ApiAction` component that exposes an async submit handler.
+ */
 export interface ApiActionProps<
  Params extends object,


Off-scope for this PR, but extends object is a footgun as it doesn't really mean anything since everything except primitives are objects. (I.e. it's not like saying something is a Dict in Python.)

There was some good reason for this, but can't remember anymore. Was probably something to do with how the ts-api fetch function arguments work

anttimaki · 2025-11-28T12:10:31Z

packages/ts-api-react-actions/src/ApiAction.tsx


-// As of this moment ApiActions sole purpose is to gracefully handle errors from API calls
+/**
+ * Component that wraps an API endpoint in a stable submit callback with mapped errors.


Nitpick: maybe it's just me but I have hard time grasping this comment.

anttimaki · 2025-11-28T12:13:36Z

packages/ts-api-react-actions/src/useApiAction.ts

 import { ApiEndpointProps } from "@thunderstore/thunderstore-api";

+/**
+ * Configuration for wiring `useApiAction` to a specific API endpoint.


Nitpick: generally speaking I don't know if "FooArgs" or "BarProps" benefit that much for having a docstring. "Foo" and "Bar" are more natural places to comment on what the thing actually does (if any extra clarification is needed).

anttimaki · 2025-11-28T12:18:26Z

packages/ts-api-react-actions/src/useApiAction.ts

+      props: ApiEndpointProps<Params, QueryParams, Data>
+    ): Promise<Awaited<Return>> => {
+      const result = await apiCall(props);
+      return result as Awaited<Return>;


According to my IDE this as assertion is not required, and you should avoid unnecessary assertions as they can hide bugs.

anttimaki · 2025-11-28T12:56:00Z

apps/cyberstorm-remix/cyberstorm/utils/StrongForm/useStrongForm.ts


-interface UseStrongFormProps<
-  Inputs,
+type IsExact<A, B> = (<T>() => T extends A ? 1 : 2) extends <T>() => T extends B


Now here I would welcome a good docstring explaining IsExact, RefinerRequirement, and ErrorMapperRequirement.

anttimaki · 2025-11-28T12:57:54Z

apps/cyberstorm-remix/cyberstorm/utils/StrongForm/useStrongForm.ts


-export function useStrongForm<
+/**
+ * Configuration for wiring a StrongForm instance to refiners, submitters and lifecycle hooks.


Nitpick: but instead I get "here be props" and "here be return type" level comments 😔 A hard-knock life.

anttimaki · 2025-11-28T13:14:56Z

apps/cyberstorm-remix/cyberstorm/utils/StrongForm/useStrongForm.ts

+    return mapApiErrorToUserFacingError(error);
+  };
+
+  const mapError: (error: unknown) => SubmissionError =


My IDE flags this for type error, and I don't know why this variable is even used since it's called in only one place, and why it's defined here since the call site comes way later.

anttimaki · 2025-11-28T13:29:19Z

apps/cyberstorm-remix/cyberstorm/utils/StrongForm/useStrongForm.ts

+  const mapError: (error: unknown) => SubmissionError =
+    props.errorMapper ?? defaultErrorMapper;
+
+  useEffect(() => {


The whole strongForm concept confuses me to the level that I don't even attempt to review it with my fried Friday brain.

You know, it confuses me nowadays too. But it does work

Could be even better though

anttimaki · 2025-11-28T13:29:27Z

packages/cyberstorm-forms/src/useFormToaster.ts

+  formatUserFacingError,
+} from "@thunderstore/thunderstore-api";

 export type UseFormToasterArgs<OnSubmitSuccessDataType, OnSubmitErrorDataType> =


Off-scope but my gut feeling is that the whole useFormToaster is overengineered on the concept level and quite confusing if the point is to just show toasts.

You are not incorrect, but I don't have a solution off the top of my head, probably a worthy non-mission-critical task

…s with user-facing error mapping

…rent file

…ing error mapping

This was referenced Nov 19, 2025

Implement Nimbus error handling components and utilities for consistent user-facing error messages #1613

Open

(thunderstore-api) Implement user-facing error handling improvements and update tests for authentication errors #1614

Open

VilppeRiskidev approved these changes Nov 24, 2025

View reviewed changes

Oksamies marked this pull request as ready for review November 27, 2025 11:55

anttimaki reviewed Nov 28, 2025

View reviewed changes

Oksamies changed the base branch from 11-19-refactor_api_methods_to_remove_unnecessary_async_await_and_improve_return_handling to graphite-base/1616 December 2, 2025 13:09

Oksamies mentioned this pull request Dec 2, 2025

chore: migrate build system to Vite and update TS config #1648

Open

Oksamies force-pushed the graphite-base/1616 branch from 06e02e3 to e40ef67 Compare December 2, 2025 13:10

Oksamies force-pushed the 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping branch from cd40580 to 5ac0d36 Compare December 2, 2025 13:10

Oksamies changed the base branch from graphite-base/1616 to 11-19-refactor_api_methods_to_remove_unnecessary_async_await_and_improve_return_handling December 2, 2025 13:10

Oksamies added 4 commits December 3, 2025 03:11

(ts-api-react-actions) Enhance error handling in API actions and hook…

d34702c

…s with user-facing error mapping

Refactor loader functions to enhance error handling and move to diffe…

4a25139

…rent file

Enhance error handling in StrongForm and useFormToaster with user-fac…

689944f

…ing error mapping

Correct error handling related imports and types

de2572f

Oksamies changed the base branch from 11-19-refactor_api_methods_to_remove_unnecessary_async_await_and_improve_return_handling to graphite-base/1616 December 3, 2025 01:45

Oksamies force-pushed the 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping branch from 5ac0d36 to de2572f Compare December 3, 2025 01:46

Oksamies force-pushed the graphite-base/1616 branch from e40ef67 to ee03845 Compare December 3, 2025 01:46

Oksamies changed the base branch from graphite-base/1616 to 11-19-refactor_api_methods_to_remove_unnecessary_async_await_and_improve_return_handling December 3, 2025 01:46

(ts-api-react-actions) Enhance error handling in API actions and hooks with user-facing error mapping #1616

Are you sure you want to change the base?

(ts-api-react-actions) Enhance error handling in API actions and hooks with user-facing error mapping #1616

Uh oh!

Conversation

Oksamies commented Nov 19, 2025

Uh oh!

coderabbitai bot commented Nov 19, 2025

Review skipped

Uh oh!

Oksamies commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Oksamies commented Nov 19, 2025 •

edited

Loading