chore: centralize eslint toolchain versions with pnpm catalog#634
Merged
Conversation
The eslint toolchain was declared with identical version specs in two manifests (root package.json and packages/react-ui). Move those specs into the pnpm catalog and reference them via the "catalog:" protocol so the version lives in a single place, mirroring thesysdev#612. Cataloged (no declared-version changes — root and react-ui already shared one spec each): - @typescript-eslint/eslint-plugin "^8.56.1" - eslint "^9.0.0" - eslint-config-prettier "^10.1.8" - eslint-plugin-prettier "^5.5.5" - eslint-plugin-react-hooks "^7.0.1" - eslint-plugin-react-refresh "^0.5.2" - eslint-plugin-storybook "^10.2.14" - eslint-plugin-unused-imports "^4.4.1" The lockfile churn is pnpm deduping a stale transitive @typescript-eslint 8.56.1 sub-tree onto 8.59.4; the top-level eslint-plugin already resolved to 8.59.4, so no top-level resolution moved. Scope: examples/ and docs/ use a looser `eslint: ^9` plus eslint-config-next (which no workspace package uses), so folding them in would change resolved specs rather than just centralizing them — left out to match thesysdev#612's "no resolved-version changes" principle. Verified: react-ui lint:check passes (eslint v9.29.0 resolved from the catalog, plugins load, 0 errors). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Shinyaigeek
force-pushed
the
chore/catalog-eslint
branch
from
c07b301 to
0e7513a
Compare
vishxrad
approved these changes
Jun 11, 2026
vishxrad
left a comment
vishxrad
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for your contribution :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move the eslint toolchain version specs into the pnpm
catalog:and reference them from the consuming manifests, so each version is declared in one place. Follows the pattern established in #612.Why
The eslint toolchain was declared with identical version specs in two manifests — the root
package.jsonandpackages/react-ui/package.json. Centralizing them in the catalog removes the duplication and keeps the two in lockstep going forward.Cataloged
No declared-version changes — root and react-ui already shared one spec each:
@typescript-eslint/eslint-plugin^8.56.1eslint^9.0.0eslint-config-prettier^10.1.8eslint-plugin-prettier^5.5.5eslint-plugin-react-hooks^7.0.1eslint-plugin-react-refresh^0.5.2eslint-plugin-storybook^10.2.14eslint-plugin-unused-imports^4.4.1Scope
examples/anddocs/use a loosereslint: ^9pluseslint-config-next(which no workspace package uses), so folding them in would change resolved specs rather than just centralizing them. Left out to match #612's "no resolved-version changes" principle. The otherpackages/*don't declare eslint themselves (they rely on hoisting), so there was nothing to convert.Lockfile churn
The diff is large because
pnpm installdeduped a stale transitive@typescript-eslint8.56.1sub-tree onto8.59.4. The top-level@typescript-eslint/eslint-pluginalready resolved to8.59.4before this change, so no top-level resolution moved.Verification
pnpm installclean (only pre-existing, unrelated peer warnings)pnpm --filter @openuidev/react-ui run lint:checkpasses — eslintv9.29.0resolves from the catalog, plugins load, 0 errors (pre-existingreact-hooks/exhaustive-depswarnings only)🤖 Generated with Claude Code