chore: centralize typescript version with pnpm catalog#645
Open
Shinyaigeek wants to merge 2 commits into
Open
Conversation
typescript was declared as a devDependency with divergent specs across the library packages and the monorepo root (`^5.9.3`, `^5`, `^5.0.0`). Move the version into the pnpm catalog and reference it via the "catalog:" protocol so the toolchain version lives in one place, mirroring thesysdev#612/thesysdev#624/thesysdev#634. Cataloged spec: `^5.9.3` (the root's existing spec). - package.json `^5.9.3` -> catalog: - packages/react-email `^5` -> catalog: - packages/svelte-lang `^5.0.0` -> catalog: - packages/vue-lang `^5.0.0` -> catalog: No resolved-version change: every importer already resolved to typescript@5.9.3, so this only tightens the declared specs onto the single catalog entry. examples/ and docs/ keep their inline `^5`/`~5.9.2` specs, matching thesysdev#612's library-only scope. Verified: react-email/svelte-lang/vue-lang build + typecheck pass with typescript 5.9.3 resolved from the catalog. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
`svelte-check` failed on src/__tests__/library.test.ts: the root tsconfig enables `noPropertyAccessFromIndexSignature`, and `lib.components` carries a string index signature, so dot access (`lib.components.TextContent`) is rejected. The parallel vue-lang test already uses bracket access; bring svelte-lang in line. Pre-existing on main, surfaced while verifying the catalog change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
typescriptwas declared as a devDependency with divergent specs across the library packages and the monorepo root. Move the version into the pnpm catalog and reference it via thecatalog:protocol so the toolchain version lives in one place — mirroring #612 / #624 / #634.Cataloged spec:
^5.9.3(the root's existing spec).package.json(root)^5.9.3catalog:packages/react-email^5catalog:packages/svelte-lang^5.0.0catalog:packages/vue-lang^5.0.0catalog:No resolved-version change
Every importer already resolved to
typescript@5.9.3, so this only tightens the declared specs onto the single catalog entry — the lockfile diff is just the four specifiers flipping tocatalog:plus the new catalog entry.examples/anddocs/keep their inline^5/~5.9.2specs, matching #612's library-only scope.Drive-by fix
fix(svelte-lang): the testsrc/__tests__/library.test.tsused dot access onlib.components(a string-index-signature type), whichnoPropertyAccessFromIndexSignature(set in the root tsconfig) rejects. Switched to bracket access, matching the parallelvue-langtest. This was already failingsvelte-checkonmain; surfaced while verifying this change.Verification
react-email,svelte-lang,vue-lang: build + typecheck/check pass withtypescript@5.9.3resolved from the catalog.svelte-langvitest: 30/30 pass.pnpm install --frozen-lockfile: clean (lockfile consistent with manifests).🤖 Generated with Claude Code