Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions lib/base/connection-pool.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,16 @@ class ConnectionPool extends EventEmitter {
switch (key) {
case 'application name':
break
case 'applicationintent':
Object.assign(config.options, {
readOnlyIntent: value === 'readonly'
})
case 'applicationintent': {
// the value is not case-sensitive; an empty value is not set
const intent = value.trim().toLowerCase()
if (intent) {
Object.assign(config.options, {
readOnlyIntent: intent === 'readonly'
})
}
break
}
case 'asynchronous processing':
break
case 'attachdbfilename':
Expand Down
38 changes: 38 additions & 0 deletions test/common/unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -869,8 +869,46 @@ describe('connection string encrypt option', () => {
})
})

describe('connection string application intent option', () => {
it('does not set readOnlyIntent when ApplicationIntent is left out', () => {
const config = BasePool._parseConnectionString('Server=localhost')
assert.strictEqual('readOnlyIntent' in config.options, false)
})

it('does not set readOnlyIntent when ApplicationIntent is empty', () => {
const config = BasePool._parseConnectionString('Server=localhost;ApplicationIntent=;Database=db')
assert.strictEqual('readOnlyIntent' in config.options, false)
assert.strictEqual(config.database, 'db')
})

it('does not set readOnlyIntent when ApplicationIntent is only whitespace', () => {
const config = BasePool._parseConnectionString('Server=localhost;ApplicationIntent={ }')
assert.strictEqual('readOnlyIntent' in config.options, false)
})

for (const value of ['ReadOnly', 'readonly', 'READONLY', ' ReadOnly ', '{ ReadOnly }']) {
it(`parses ApplicationIntent=${value} as read-only intent`, () => {
const config = BasePool._parseConnectionString(`Server=localhost;ApplicationIntent=${value}`)
assert.strictEqual(config.options.readOnlyIntent, true)
})
}

for (const value of ['ReadWrite', 'readwrite']) {
it(`parses ApplicationIntent=${value} as read-write intent`, () => {
const config = BasePool._parseConnectionString(`Server=localhost;ApplicationIntent=${value}`)
assert.strictEqual(config.options.readOnlyIntent, false)
})
}

it('uses ApplicationIntent=ReadOnly in the tedious config', () => {
const config = new ConnectionPool('Server=localhost;ApplicationIntent=ReadOnly')._config()
assert.strictEqual(config.options.readOnlyIntent, true)
})
})

describe('connection string empty values', () => {
const keys = [
'ApplicationIntent',
'Connection Timeout',
'ConnectRetryInterval',
'Encrypt',
Expand Down