Repository navigation
fix: parse the connection string ApplicationIntent value without case - #1966
Merged
dhensby merged 1 commit intoNov 20, 2026
Merged
Conversation
The parser set readOnlyIntent only for the all-lowercase value "readonly". ApplicationIntent=ReadOnly, the casing in the Microsoft docs, gave a read-write connection. Compare the trimmed value without case. An empty value now gives the same config as a left-out key, so the driver default applies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🎉 This PR is included in version 12.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does:
The connection string parser set
readOnlyIntentonly when theApplicationIntentvalue was the all-lowercasereadonly.ApplicationIntent=ReadOnly, the casing in the Microsoft docs, gave a read-write connection with no error.The parser now trims the value and compares it without case.
ApplicationIntent=ReadOnlyreadOnlyIntent: falsereadOnlyIntent: trueApplicationIntent=READONLYreadOnlyIntent: falsereadOnlyIntent: trueApplicationIntent={ ReadOnly }readOnlyIntent: falsereadOnlyIntent: trueApplicationIntent=readonlyreadOnlyIntent: truereadOnlyIntent: trueApplicationIntent=ReadWritereadOnlyIntent: falsereadOnlyIntent: falseApplicationIntent=orApplicationIntent={ }readOnlyIntent: false@tediousjs/connection-stringtrims unquoted values but keeps the spaces in a braced value, so node-mssql trims the value itself. An empty value now gives the same config as a left-out key, which matches the empty-value handling from #1960 and #1961. Other values still givereadOnlyIntent: false.The new unit tests cover each row above and the tedious
_config()output. The case, whitespace and empty-value tests fail before the fix and pass after it. Lint and all 378 unit tests pass. No live SQL Server integration tests were run.Related issues:
ApplicationIntent=ReadOnlydid not set read-only intent.Pre/Post merge checklist:
🤖 Generated with Claude Code