Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/ast-grep-upgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ jobs:
if: steps.detect.outputs.update == 'true'
run: pnpm install --lockfile-only --ignore-scripts

# "upgrade to", the same verb vale-upgrade.yml uses, because it is the
# same operation: moving the pins a user resolves. ast-grep has no
# "accept upstream" counterpart, since nothing here repackages it.
#
# Every value reaching the shell goes through `env:` rather than `${{ }}`
# interpolation into the script body. The branch and pull request
# lifecycle is `vendor-pr.cjs`, shared with release-vale.yml.
Expand Down Expand Up @@ -179,7 +183,7 @@ jobs:

node .github/scripts/vendor-pr.cjs \
--branch vendor/ast-grep/upgrade \
--title "chore(ast-grep): pin ast-grep ${SG_VERSION}" \
--message "chore(ast-grep): pin ast-grep ${SG_VERSION}" \
--title "chore(ast-grep): upgrade to ast-grep ${SG_VERSION}" \
--message "chore(ast-grep): upgrade to ast-grep ${SG_VERSION}" \
--body-file "$body" \
-- packages/cli/package.json pnpm-lock.yaml "$changeset"
15 changes: 12 additions & 3 deletions .github/workflows/release-vale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,13 @@ jobs:
# validated as major.minor.patch by the script, but the pattern is the
# rule regardless of the value.
#
# "accept upstream", not "pin". This proposal changes NOTHING a consumer
# installs: it records which upstream release we are willing to package
# and republish. The pins a user resolves move in `vale-upgrade.yml`,
# whose PR says "upgrade to". Two stages, two verbs, so a title says which
# one you are looking at — they otherwise differ only in the word `pin`,
# which was on the wrong one.
#
# The branch and pull request lifecycle is `vendor-pr.cjs`, shared with
# every vendor workflow: one rolling `vendor/vale/republish` branch,
# rebuilt from `main`, retitled and rewritten as upstream moves, and
Expand Down Expand Up @@ -222,7 +229,9 @@ jobs:
Merging this triggers the publish phase, which stamps every platform
package `<valeVersion>-<yyyymmddhhmmss>` and publishes the set. That
publish is inert on its own: `@taskless/cli` pins exact versions, so
nothing reaches a consumer until that pin is deliberately bumped.
nothing reaches a consumer until that pin is deliberately bumped —
which is what `vale-upgrade.yml` proposes, separately, once this has
merged and published. Merging THIS changes nobody's install.

This pull request rolls: if upstream releases again before it merges,
the branch, title, and body are rewritten to the newer version rather
Expand All @@ -243,8 +252,8 @@ jobs:

node .github/scripts/vendor-pr.cjs \
--branch vendor/vale/republish \
--title "chore(vale): pin Vale ${VALE_VERSION}" \
--message "chore(vale): pin Vale ${VALE_VERSION}" \
--title "chore(vale): accept upstream Vale ${VALE_VERSION}" \
--message "chore(vale): accept upstream Vale ${VALE_VERSION}" \
--body-file "$body" \
--label skip-changeset \
-- .github/scripts/vale-manifest.json
Expand Down
Loading