ci: name each vendor stage for what it actually does - #335
Merged
Merged
Conversation
The republish PR was titled "pin Vale <version>", which is the one thing it does not do. It updates the manifest and, on merge, republishes the six @taskless/vale-* packages; the pins a user resolves do not move until vale-upgrade.yml proposes it separately. With both stages now automated, the two Vale PRs differed only in the word "pin" — and it was on the wrong one. Each stage now says what it is: chore(vale): accept upstream Vale 3.21.0 republish, changes no install chore(vale): upgrade to Vale 3.21.0 moves the pins, ships it chore(ast-grep): upgrade to ast-grep 0.45.3 moves the pins, ships it ast-grep moves to "upgrade to" as well. It is the same operation as the Vale upgrade and was reading as a third kind of change; ast-grep simply has no "accept upstream" counterpart, because nothing here repackages it. The republish body also now points at the stage that does reach a consumer, so a reviewer looking at digests knows this is not that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#333is titled "chore(vale): pin Vale 3.21.0", which is the one thing that PR does not do.The problem
With both Vale stages now automated, the two PRs differed only in the word
pin— and it was on the wrong one:@taskless/vale-*. Changes no install.release-vale.yml's own body already says "nothing reaches a consumer until that pin is deliberately bumped" — so the title claiming to be that bump contradicted the body two paragraphs below it.After
One verb per operation, so a title says which stage you are looking at.
ast-grep moves to "upgrade to" as well. It was titled "pin ast-grep", which is accurate in isolation but read as a third kind of change next to the other two. It is the same operation as the Vale upgrade and now says so. ast-grep has no "accept upstream" counterpart because nothing here repackages it — that asymmetry is real and is noted in the workflow.
The republish body also now points at the stage that does reach a consumer, so a reviewer weighing digests knows this is not that one.
Scope
Titles, commit messages, and the comments explaining them. No behaviour change —
vendor-pr.cjspasses whatever title it is given, and both workflow shells were re-syntax-checked. 432 script tests and lint pass.Open PRs #333 and #334 are retitled in place to match, so nothing reads as the old scheme while this lands.