Skip to content

Retry release asset uploads in CI #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jserv merged 1 commit into from
Nov 2, 2026
+18 −2
Merged

Retry release asset uploads in CI #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,7 +1152,15 @@ jobs:

gh release create "$staged" --draft --target "$GITHUB_SHA" \
--title "$tag" --notes "Automated build of ${GITHUB_SHA:0:7}."
gh release upload "$staged" "${assets[@]}"
# An upload can time out (HTTP 408) on the GitHub side with nothing
# wrong in the build. --clobber replaces an asset a cut-off attempt
# left behind, so trying again is safe.
for attempt in 1 2 3; do
gh release upload --clobber "$staged" "${assets[@]}" && break
[ "$attempt" -lt 3 ] || exit 1
echo "upload failed; trying again (attempt $attempt of 3)" >&2
sleep $((attempt * 10))
done

# Sizes, not just presence: an upload cut off partway still leaves a
# named asset behind, and a truncated binary is the one outcome this
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,15 @@ jobs:
gh release create "$staged" --draft --prerelease --latest=false \
--target "$GITHUB_SHA" --title "CodeTrial desktop (main)" \
--notes "Automated desktop build of ${GITHUB_SHA:0:7}. The installers are not signed yet; docs/desktop.md lists what that means on each platform."
gh release upload "$staged" "${assets[@]}"
# An upload can time out (HTTP 408) on the GitHub side with nothing
# wrong in the build. --clobber replaces an asset a cut-off attempt
# left behind, so trying again is safe.
for attempt in 1 2 3; do
gh release upload --clobber "$staged" "${assets[@]}" && break
[ "$attempt" -lt 3 ] || exit 1
echo "upload failed; trying again (attempt $attempt of 3)" >&2
sleep $((attempt * 10))
done

# Sizes, not just presence: a cut-off upload still leaves a named
# asset behind.
Expand Down
Loading