Repository navigation
Conversation
The rolling jobs of the desktop and check workflows stage a draft release and upload the installers in one attempt. GitHub answered one upload with HTTP 408 (body timed out), which failed the desktop job although every build had succeeded. Try each upload up to three times with a growing pause, and pass --clobber so an asset a cut-off attempt left behind is replaced rather than refused. The size check that follows still fails the job on a truncated or missing asset. Change-Id: I2d9092d7df3f297850ed3c33ce017e30a3de31f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop workflow's rolling job failed on main (run 41514226247) with
HTTP 408: Upload body timed outwhile uploading one installer to the staged draft release, although all three platform builds had succeeded. The same single-attempt upload exists in thelatestrelease job of check.yml.Each upload is now tried up to three times with a growing pause, and
--clobberreplaces an asset a cut-off attempt left behind instead of refusing it. The size check after the upload is unchanged, so a truncated or missing asset still fails the job.Verified: both workflow files parse as YAML, and codex and claude reviewed the loop read-only and found nothing wrong under
bash -e -o pipefail, including the EXIT trap that deletes the draft after a third failure. The upload paths only run on main, so the retry itself has not been exercised; whether--clobbersees a half-written asset is unconfirmed until a real timeout hits it.Summary by cubic
Retries GitHub release asset uploads in the desktop and check workflows so a transient
HTTP 408: Upload body timed outno longer fails the job even though all builds succeeded. Each upload is tried up to three times with a growing pause, and--clobberreplaces an asset a cut-off attempt left behind. The size check that follows still fails the job on a truncated or missing asset.Written for commit 61f5858. Summary will update on new commits.