feat(tools): 7-tool parity and description refresh - #1432
Open
Dhravya wants to merge 2 commits into
Open
Conversation
Update shared tool descriptions (proactive search, documentAdd guidance), export TOOL_DESCRIPTIONS from package index, and align OpenAI/AI SDK tool schemas with memoryForget and document operations. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
supermemory-mcp | d5937b8 | Aug 08 2026, 02:48 AM |
Code Review in Progress
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
supermemory-app | d5937b8 | Aug 08 2026, 02:47 AM |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+165
to
+180
| it.each(["$&", "$'", "$`", "$$"])( | ||
| "stores %s literally instead of expanding it as a replacement pattern", | ||
| async (dollarSequence) => { | ||
| const result = await tool.handleCommand({ | ||
| command: "str_replace", | ||
| path: FILE_PATH, | ||
| old_str: "line3", | ||
| new_str: `price is ${dollarSequence} today`, | ||
| }) | ||
|
|
||
| expect(result.success).toBe(true) | ||
| expect(addMock).toHaveBeenCalledTimes(1) | ||
| const stored = addMock.mock.calls[0]?.[0]?.content as string | ||
| expect(stored).toContain(`price is ${dollarSequence} today`) | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Test regression: the assertion expect(stored).not.toContain("line3") was removed during reformatting. The test now only verifies the new string was added but doesn't verify the old string was actually replaced. This weakens test coverage and won't catch if str_replace fails to remove the old content.
expect(stored).toContain(`price is ${dollarSequence} today`)
expect(stored).not.toContain("line3") // Add this back
Suggested change
| it.each(["$&", "$'", "$`", "$$"])( | |
| "stores %s literally instead of expanding it as a replacement pattern", | |
| async (dollarSequence) => { | |
| const result = await tool.handleCommand({ | |
| command: "str_replace", | |
| path: FILE_PATH, | |
| old_str: "line3", | |
| new_str: `price is ${dollarSequence} today`, | |
| }) | |
| expect(result.success).toBe(true) | |
| expect(addMock).toHaveBeenCalledTimes(1) | |
| const stored = addMock.mock.calls[0]?.[0]?.content as string | |
| expect(stored).toContain(`price is ${dollarSequence} today`) | |
| }, | |
| ) | |
| it.each(["$&", "$'", "$`", "$$"])( | |
| "stores %s literally instead of expanding it as a replacement pattern", | |
| async (dollarSequence) => { | |
| const result = await tool.handleCommand({ | |
| command: "str_replace", | |
| path: FILE_PATH, | |
| old_str: "line3", | |
| new_str: `price is ${dollarSequence} today`, | |
| }) | |
| expect(result.success).toBe(true) | |
| expect(addMock).toHaveBeenCalledTimes(1) | |
| const stored = addMock.mock.calls[0]?.[0]?.content as string | |
| expect(stored).toContain(`price is ${dollarSequence} today`) | |
| expect(stored).not.toContain("line3") // Add this back | |
| }, | |
| ) | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
Dhravya
force-pushed
the
feat/tools-seven-tool-parity
branch
from
August 8, 2026 02:47
222bda0 to
d5937b8
Compare
1 task
Member
Author
This was referenced Aug 8, 2026
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools-shared.tsTOOL_DESCRIPTIONS/PARAMETER_DESCRIPTIONSfrom package indexStacked on #1431
Test plan
bun run test:unitinpackages/toolsMade with Cursor