feat(openai-sdk-python): 7-tool parity - #1430
Conversation
Add document_list, document_add, document_delete, get_profile, and memory_forget alongside search_memories and add_memory. Includes forget_memory HTTP helper and expanded tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-mcp | 1160c46 | Aug 08 2026, 02:40 AM |
|
Claude finished @Dhravya's task in 1m 10s —— View job Code Review Complete
Overview: Expands the OpenAI Python SDK from 2 tools to 7 (search, add, get_profile, document_list/add/delete, memory_forget) with a new HTTP helper for the forget endpoint. Issues found:
Score: 8/10 The code is well-structured with proper error handling, good validation (e.g., rejecting both |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview: Expands the OpenAI Python SDK from 2 tools to 7 (search, add, get_profile, document_list/add/delete, memory_forget) with a new HTTP helper for the forget endpoint.
Issues found:
forget_memory.py:46— The async function uses synchronousrequestsin the fallback path, which blocks the event loop. Fix by wrapping inasyncio.to_thread().
Score: 8/10
The code is well-structured with proper error handling, good validation (e.g., rejecting both project_id and container_tags), and comprehensive test coverage. The one issue above should be fixed before merge to avoid blocking async applications when aiohttp isn't installed.
| except ImportError: | ||
| import requests | ||
|
|
||
| response = requests.delete( |
There was a problem hiding this comment.
Bug: Synchronous I/O blocks the event loop
This async function falls back to synchronous requests when aiohttp isn't installed. Since requests.delete() is blocking, it will freeze the entire event loop until the HTTP request completes — potentially causing timeouts or deadlocks in async applications.
Since Python 3.9 is now the minimum version, use asyncio.to_thread() to run the blocking call in a thread pool:
except ImportError:
import asyncio
import requests
def _sync_delete() -> requests.Response:
return requests.delete(
f"{base_url}/v4/memories",
headers={
"Content-Type": "application/json",
"Authorization": f"Bearer {api_key}",
},
json=payload,
timeout=30,
)
response = await asyncio.to_thread(_sync_delete)
if not response.ok:
raise RuntimeError(
f"Supermemory forget memory failed: {response.status_code} "
f"{response.reason}. {response.text}"
)![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1160c46. Configure here.
| return ProfileResult( | ||
| success=True, | ||
| profile=profile if isinstance(profile, dict) else None, | ||
| search_results=search_results, |
There was a problem hiding this comment.
Profile dropped on success
High Severity
get_profile marks success but sets profile to null whenever the SDK returns a Pydantic profile object, because only dict instances are kept. Real client.profile() responses use models, so the tool often returns an empty profile despite a successful API call.
Reviewed by Cursor Bugbot for commit 1160c46. Configure here.
| "error": f"Unknown function: {function_name}", | ||
| } | ||
| else: | ||
| result = await handler(**args) |
There was a problem hiding this comment.
Tool JSON serialization fails
High Severity
execute_tool_call uses plain json.dumps on handler results, but get_profile and document_list can embed SDK Pydantic objects (search_results, document rows, pagination). That raises TypeError and breaks tool execution when those tools run through OpenAI function calling.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 1160c46. Configure here.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 1160c46 | Commit Preview URL Branch Preview URL |
Aug 08 2026, 02:42 AM |
1 participant
Summary
SupermemoryToolsfrom 2 tools to 7 (matches@supermemory/tools)memory_forgetvia shared HTTP helperStacked on #1429
Test plan
uv run pytest tests/test_tools.py::TestMemoryOperationsUnitMade with Cursor