chore(cli): bring /shared under the effect skill

apps/cli/src/commands/functions/deploy/deploy.integration.test.ts

@@ -2,7 +2,9 @@ import { BunServices } from "@effect/platform-bun";
 import { describe, expect, it } from "@effect/vitest";
 import {
   Cause,
+  Clock,
   Deferred,
+  Duration,
   Effect,
   Exit,
   Fiber,
@@ -11,10 +13,12 @@ import {
   Option,
   Path,
   Predicate,
+  Queue,
   Schema,
   Stdio,
 } from "effect";
 import * as HttpClientResponse from "effect/http/HttpClientResponse";
+import { TestClock } from "effect/testing";
 
 import { YesFlag } from "../../../command-internal/global-flags.ts";
 import { stripControlSequences } from "../../../shared/output/strip-control-sequences.ts";
@@ -757,12 +761,37 @@ describe("functions deploy", () => {
   function apiDeployHarness(
     handler: ApiHandler,
     args: ReadonlyArray<string> = ["functions", "deploy", "hello-world", "--use-api"],
+    rateLimitNotices?: Queue.Enqueue<string>,
   ) {
     const out = mockOutput({ format: "text" });
     const api = mockCommandPlatformApi({ handler });
     const layer = Layer.mergeAll(
       buildTestRuntime({
-        out,
+        out:
+          rateLimitNotices === undefined
+            ? out
+            : {
+                ...out,
+                layer: Layer.effect(
+                  Output,
+                  Effect.gen(function* () {
+                    const output = yield* Output;
+                    return {
+                      ...output,
+                      raw: (text: string, stream?: "stdout" | "stderr") =>
+                        output
+                          .raw(text, stream)
+                          .pipe(
+                            Effect.tap(() =>
+                              text.startsWith("Rate limit exceeded")
+                                ? Queue.offer(rateLimitNotices, text)
+                                : Effect.void,
+                            ),
+                          ),
+                    };
+                  }),
+                ).pipe(Layer.provide(out.layer)),
+              },
         api,
         cliSettings: mockCommandSettings({ workdir: tempRoot.current }),
         runtimeInfo: mockRuntimeInfo({ cwd: tempRoot.current }),
@@ -994,6 +1023,85 @@ describe("functions deploy", () => {
     }).pipe(Effect.provide(layer), Effect.ensuring(removeTempRoot));
   });
 
+  it.effect("gives up on a persistent rate limit after the command's backoff schedule", () =>
+    Effect.gen(function* () {
+      const notices = yield* Queue.unbounded<string>();
+      const deployTimes: Array<number> = [];
+      const { layer } = apiDeployHarness(
+        (request) =>
+          request.method === "GET"
+            ? Effect.succeed(jsonResponse(request, 200, []))
+            : Effect.gen(function* () {
+                deployTimes.push(yield* Clock.currentTimeMillis);
+                return HttpClientResponse.fromWeb(request, new Response("{}", { status: 429 }));
+              }),
+        undefined,
+        notices,
+      );
+
+      yield* Effect.gen(function* () {
+        yield* writeCliConfig(tempRoot.current);
+        yield* writeLocalFunction(tempRoot.current, "hello-world");
+
+        const deploy = yield* Effect.forkChild(functionsDeploy(baseFlags));
+        for (const seconds of [1, 2, 4, 8, 16, 32, 32, 32]) {
+          expect(yield* Queue.take(notices)).toBe(
+            `Rate limit exceeded while deploying function hello-world. Retrying in ${seconds}s.\n`,
+          );
+          yield* TestClock.adjust(Duration.seconds(seconds));
+        }
+        const error = yield* Fiber.join(deploy).pipe(Effect.flip);
+
+        expect(error).toBeInstanceOf(FunctionsApiStatusError);
+        expect(error).toMatchObject({ status: 429 });
+        expect(deployTimes).toEqual([
+          0, 1_000, 3_000, 7_000, 15_000, 31_000, 63_000, 95_000, 127_000,
+        ]);
+      }).pipe(Effect.provide(layer), Effect.ensuring(removeTempRoot));
+    }),
+  );
+
+  it.effect("waits for the server's retry-after before retrying a rate-limited deploy", () =>
+    Effect.gen(function* () {
+      const notices = yield* Queue.unbounded<string>();
+      let deployAttempts = 0;
+      const { layer, api } = apiDeployHarness(
+        (request, recorded) => {
+          if (request.method === "GET") return Effect.succeed(jsonResponse(request, 200, []));
+          deployAttempts += 1;
+          if (deployAttempts === 1) {
+            return Effect.succeed(
+              HttpClientResponse.fromWeb(
+                request,
+                new Response("{}", { status: 429, headers: { "retry-after": "3" } }),
+              ),
+            );
+          }
+          return deployedHelloWorld(request, recorded);
+        },
+        undefined,
+        notices,
+      );
+      const deployRequests = () => api.requests.filter((request) => request.method === "POST");
+
+      yield* Effect.gen(function* () {
+        yield* writeCliConfig(tempRoot.current);
+        yield* writeLocalFunction(tempRoot.current, "hello-world");
+
+        const deploy = yield* Effect.forkChild(functionsDeploy(baseFlags));
+        expect(yield* Queue.take(notices)).toBe(
+          "Rate limit exceeded while deploying function hello-world. Retrying in 3s.\n",
+        );
+        yield* TestClock.adjust(Duration.millis(2_999));
+        expect(deployRequests()).toHaveLength(1);
+        yield* TestClock.adjust(Duration.millis(1));
+        yield* Fiber.join(deploy);
+
+        expect(deployRequests()).toHaveLength(2);
+      }).pipe(Effect.provide(layer), Effect.ensuring(removeTempRoot));
+    }),
+  );
+
   it.effect("reports a malformed functions list with the schema decoder's message", () => {
     const { layer } = apiDeployHarness((request) =>
       Effect.succeed(

apps/cli/src/shared/auth/jwks.integration.test.ts

@@ -8,7 +8,7 @@ import { resolveRemoteJwks } from "./jwks.ts";
 const issuer = "https://issuer.example";
 
 describe("remote signing keys", () => {
-  it.live("discovers the key URL and preserves the provider's key payload", () =>
+  it.effect("discovers the key URL and preserves the provider's key payload", () =>
     Effect.gen(function* () {
       const requested: string[] = [];
       const keys = [{ kty: "RSA", kid: "key-1", custom: true }];
@@ -31,7 +31,7 @@ describe("remote signing keys", () => {
     { name: "missing discovery key URL", status: 200, body: {} },
     { name: "empty key document", status: 200, body: { keys: [] } },
   ]) {
-    it.live(`rejects ${response.name}`, () =>
+    it.effect(`rejects ${response.name}`, () =>
       Effect.gen(function* () {
         const client = HttpClient.make((request) =>
           Effect.succeed(
@@ -73,7 +73,7 @@ describe("remote signing keys", () => {
     }),
   );
 
-  it.live("caller interruption aborts the owned request without becoming a remote error", () =>
+  it.effect("caller interruption aborts the owned request without becoming a remote error", () =>
     Effect.gen(function* () {
       const started = yield* Deferred.make<AbortSignal>();
       const client = HttpClient.make((_request, _url, signal) =>

apps/cli/src/shared/cli/command-docs.ts

@@ -1,11 +1,14 @@
 import type { Command, HelpDoc } from "effect/cli";
+import { helpDocFor } from "./subcommand-flag-suggestions.ts";
 
 // Get HelpDoc from a command (uses internal buildHelpDoc)
 export function getHelpDoc(
   command: Command.Command.Any,
   commandPath: ReadonlyArray<string>,
 ): HelpDoc.HelpDoc {
-  return (command as any).buildHelpDoc(commandPath);
+  const helpDoc = helpDocFor(command, commandPath);
+  if (helpDoc === undefined) throw new Error(`Command ${command.name} has no help doc`);
+  return helpDoc;
 }
 
 // Navigate to a subcommand by path segments

apps/cli/src/shared/cli/markdown-formatter.ts

@@ -13,10 +13,10 @@ function formatTable(headers: string[], rows: string[][]): string {
   const widths = headers.map((h, i) => Math.max(h.length, ...rows.map((r) => (r[i] ?? "").length)));
   const pad = (s: string, w: number) => s + " ".repeat(w - s.length);
 
-  const headerLine = `| ${headers.map((h, i) => pad(h, widths[i]!)).join(" | ")} |`;
+  const headerLine = `| ${headers.map((h, i) => pad(h, widths[i] ?? h.length)).join(" | ")} |`;
   const separatorLine = `| ${widths.map((w) => "-".repeat(w)).join(" | ")} |`;
   const dataLines = rows.map(
-    (row) => `| ${row.map((cell, i) => pad(cell, widths[i]!)).join(" | ")} |`,
+    (row) => `| ${row.map((cell, i) => pad(cell, widths[i] ?? cell.length)).join(" | ")} |`,
   );
 
   return [headerLine, separatorLine, ...dataLines].join("\n");

apps/cli/src/shared/cli/run.ts

@@ -12,6 +12,7 @@ import {
   Layer,
   Path,
   PlatformError,
+  Predicate,
   Runtime,
   Scope,
   Stdio,
@@ -123,7 +124,8 @@ const selfManagedSignalCommands: ReadonlyArray<ReadonlyArray<string>> = [["funct
 export function extractCommandPath(args: ReadonlyArray<string>): ReadonlyArray<string> {
   const commandArgs: Array<string> = [];
   for (let index = 0; index < args.length; index += 1) {
-    const arg = args[index]!;
+    const arg = args[index];
+    if (arg === undefined) continue;
     if (arg === "--") return commandArgs;
     if (arg.startsWith("-")) {
       const [flag] = arg.split("=", 1);
@@ -157,7 +159,8 @@ export function* rootFlagTokens(
   isValueTakingToken: (token: string) => boolean = isGlobalValueFlagToken,
 ): Generator<{ readonly token: string; readonly index: number }> {
   for (let index = 0; index < args.length; index += 1) {
-    const arg = args[index]!;
+    const arg = args[index];
+    if (arg === undefined) continue;
     if (arg === "--") return;
     if (!arg.startsWith("-")) continue;
     yield { token: arg, index };
@@ -211,7 +214,7 @@ function* shortClusterFlagNames(
 ): Generator<string> {
   if (!token.startsWith("-") || token.startsWith("--")) return;
   for (let rest = token.slice(1); rest.length > 0; rest = rest.slice(1)) {
-    const short = `-${rest[0]!}`;
+    const short = `-${rest.charAt(0)}`;
     if (isValueTakingToken(short)) return;
     if (rest[1] === "=") {
       yield short;
@@ -228,7 +231,7 @@ function shortClusterConsumesNextToken(
 ): boolean {
   if (!token.startsWith("-") || token.startsWith("--")) return false;
   for (let rest = token.slice(1); rest.length > 0; rest = rest.slice(1)) {
-    if (isValueTakingToken(`-${rest[0]!}`)) return rest.length === 1;
+    if (isValueTakingToken(`-${rest.charAt(0)}`)) return rest.length === 1;
     if (rest[1] === "=") return false;
   }
   return false;
@@ -244,7 +247,8 @@ function firstPositionalIndex(
   isValueTakingToken: (token: string) => boolean,
 ): number {
   for (let index = 0; index < args.length; index += 1) {
-    const arg = args[index]!;
+    const arg = args[index];
+    if (arg === undefined) continue;
     if (arg === "--") return index + 1;
     if (!arg.startsWith("-")) return index;
     const [flag] = arg.split("=", 1);
@@ -452,7 +456,11 @@ export function classifyParseErrorConsoleOutput(
   context: CliErrorSuggestionContext,
 ): ParseErrorConsoleDisposition {
   const error = Cause.squash(cause);
-  if (!CliError.isCliError(error) || error._tag !== "ShowHelp" || error.errors.length === 0) {
+  if (
+    !CliError.isCliError(error) ||
+    !Predicate.isTagged(error, "ShowHelp") ||
+    error.errors.length === 0
+  ) {
     return "flush-unchanged";
   }
   // `isValueTakingFlagTokenFor` only inspects the resolved leaf command's own flags, so
@@ -463,7 +471,7 @@ export function classifyParseErrorConsoleOutput(
   const isValueTakingToken = (token: string) =>
     globalFlagsWithValues.has(token) || isLeafValueTakingToken(token);
   const isSuppressedMissingFlag = (inner: (typeof error.errors)[number]) =>
-    inner._tag === "MissingOption" &&
+    Predicate.isTagged(inner, "MissingOption") &&
     !isMissingFlagTokenPresent(
       inner.option,
       context.args,
@@ -671,7 +679,7 @@ export const runCli = Effect.fnUntraced(function* <
           .pipe(Effect.map((signal) => ({ _tag: "signal" as const, signal }))),
       );
 
-      if (outcome._tag === "signal") {
+      if (Predicate.isTagged(outcome, "signal")) {
         // SIGHUP must also stay held once cleanup begins.
         yield* Effect.scoped(
           processControl.holdSignals(["SIGHUP"]).pipe(Effect.andThen(Fiber.interrupt(cliFiber))),

apps/cli/src/shared/cli/subcommand-flag-suggestions.ts

@@ -1,3 +1,4 @@
+import { Predicate } from "effect";
 import type { CliError, Command, HelpDoc } from "effect/cli";
 import { formatInvalidValueMessage } from "./invalid-value-message.ts";
 
@@ -36,7 +37,7 @@ function hasHelpDoc(command: Command.Command.Any): command is CommandWithHelpDoc
   return "buildHelpDoc" in command && typeof command.buildHelpDoc === "function";
 }
 
-function helpDocFor(
+export function helpDocFor(
   command: Command.Command.Any,
   commandPath: ReadonlyArray<string>,
 ): HelpDoc.HelpDoc | undefined {
@@ -281,7 +282,7 @@ export function formatCliErrorsForDisplay(
   let changed = false;
 
   for (const error of errors) {
-    if (error._tag === "UnrecognizedOption" && context) {
+    if (Predicate.isTagged(error, "UnrecognizedOption") && context) {
       const hint = buildSubcommandFlagHint(error, context);
       if (hint) {
         if (hint.consumedValue) suppressedUnknownSubcommands.add(hint.consumedValue);
@@ -296,12 +297,15 @@ export function formatCliErrorsForDisplay(
       }
     }
 
-    if (error._tag === "UnknownSubcommand" && suppressedUnknownSubcommands.has(error.subcommand)) {
+    if (
+      Predicate.isTagged(error, "UnknownSubcommand") &&
+      suppressedUnknownSubcommands.has(error.subcommand)
+    ) {
       changed = true;
       continue;
     }
 
-    if (error._tag === "InvalidValue") {
+    if (Predicate.isTagged(error, "InvalidValue")) {
       const message = formatInvalidValueMessage(error);
       if (message !== undefined) {
         changed = true;

apps/cli/src/shared/cli/success-trailer.ts

@@ -22,11 +22,7 @@ export const successTrailerLayer = Layer.effect(
 
     return SuccessTrailer.of({
       append: (text) => Ref.update(pending, (trailers) => [...trailers, text]),
-      takeAll: Effect.gen(function* () {
-        const trailers = yield* Ref.get(pending);
-        yield* Ref.set(pending, empty);
-        return trailers;
-      }),
+      takeAll: Ref.getAndSet(pending, empty),
       setWorkingDirectory: (cwd) => Ref.set(workingDirectory, cwd),
       workingDirectory: Ref.get(workingDirectory),
     });

apps/cli/src/shared/cli/version.ts

@@ -28,7 +28,8 @@ export function parseSemver(version: string): ParsedSemver | undefined {
     /^(0|[1-9]\d*)(?:\.(0|[1-9]\d*))?(?:\.(0|[1-9]\d*)(?:-([0-9A-Za-z-]+(?:\.[0-9A-Za-z-]+)*))?(?:\+[0-9A-Za-z-]+(?:\.[0-9A-Za-z-]+)*)?)?(?![\s\S])/.exec(
       version,
     );
-  if (match === null) return undefined;
+  const major = match?.[1];
+  if (match === null || major === undefined) return undefined;
   const prerelease = match[4] ?? "";
   if (
     prerelease
@@ -40,7 +41,7 @@ export function parseSemver(version: string): ParsedSemver | undefined {
     return undefined;
   }
   return {
-    nums: [match[1]!, match[2] ?? "0", match[3] ?? "0"],
+    nums: [major, match[2] ?? "0", match[3] ?? "0"],
     prerelease,
   };
 }