Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🤖 AI Review
Reconciled both supplied reviews and confirmed one minor test-coverage gap. No runtime defect was established. Effect dependency source is unavailable, so the schedule metadata assumptions remain unverified; tests were not run.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli/src/shared/functions/deploy.ts:1780 |
test-coverage |
claude | The rewritten 429 schedule lacks regression coverage for retry exhaustion, fallback backoff, and the displayed retry duration. Its behavior depends on schedule attempt numbering and whether tap receives the modified duration, but the existing test cannot detect mistakes in either assumption. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
most of
/sharedalready followed the effect skill after its effect lint coverage in CLI-2458,this picks up the few things that were left
whats introduced?
Effect.retryandEffect.repeatwith aSchedule, keeping the same attempts, delays and messagesserveoutcomes becomeData.TaggedEnumvalues matched with$match, and the shutdown grace usesEffect.timeoutOrElsePredicate.isTaggedand exhaustive matching replace_tagchecks, so the trace sanitizer now handles every decision explicitlyconsentencodes through EffectEffect.fnit.effectwherever the clock does not matter, and the malformed ref services test now asserts no request is sentnotes
SUPABASE_DEBUG=1span consoleref