Drop SemanticDB output from semanticdb-javac (split 1/2)#896
Draft
jupblb wants to merge 1 commit into
Draft
Conversation
8dfd0dc to
4e9b197
Compare
6c1901e to
9771e45
Compare
Rebased onto origin/main (post #899 + #900). - semanticdb-javac: replace SemanticDB protobuf emission with SCIP shards (ScipShardWriter/Aggregator/Occurrences/Symbols/Signatures + ScipVisitor). - semanticdb-kotlinc: add the SCIP shard infrastructure alongside the existing SemanticDB code path (dropped fully in stacked PR B). - scip-semanticdb: ScipShardAggregator walks per-source shards, applies SymbolRewriter, and merges into a single Index.
9771e45 to
512470c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of a 2-PR split of #891.
What this PR does
Replaces the legacy SemanticDB → SCIP conversion pipeline on the Java side with a direct, in-plugin SCIP shard emission flow. The Kotlin plugin keeps emitting SemanticDB for now and gains dual-emission so the new SCIP aggregator can read its data too. Part 2 (#TODO) drops Kotlin SemanticDB emission and removes the SemanticDB protobuf machinery entirely.
Pipeline before vs after this PR
Commits
15 commits, grouped:
ScipShardWalker,SymbolRewriter,ScipVisitor(forked fromSemanticdbVisitor),ScipSignatureFormatter,ScipShardAggregator, the opt-in--use-scip-shardsCLI flag, snapshot stabilization, and making compiler-side SCIP emission the Java plugin default.ScipVisitorno longer references SemanticDB protobuf types;semanticdb-javacemits only SCIP shards.What is NOT in this PR (deferred to #TODO)
semanticdb-kotlincemits only SCIP shards