Drop SemanticDB output from semanticdb-kotlinc and remove SemanticDB pipeline (split 2/2)#897
Draft
jupblb wants to merge 1 commit into
Draft
Drop SemanticDB output from semanticdb-kotlinc and remove SemanticDB pipeline (split 2/2)#897jupblb wants to merge 1 commit into
jupblb wants to merge 1 commit into
Conversation
9470838 to
c6a4a68
Compare
8dfd0dc to
4e9b197
Compare
b6d84da to
c2402be
Compare
6e8e91f to
130802e
Compare
ffff8b2 to
77d22d6
Compare
2ec7b8c to
6c1901e
Compare
Stacked on the Java SCIP-shard drop. semanticdb-kotlinc now bypasses the SemanticDB protobuf step entirely: the FIR visitor feeds ScipTextDocumentBuilder directly, the plug-in writes per-source *.scip shards under META-INF/scip/, and the legacy SemanticDB writers, schema, and protobuf codegen are removed. The aggregator's SemanticDB fallback and the --use-scip-shards opt-in flag are also dropped — SCIP-shard aggregation is now the only path.
77d22d6 to
45e15d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of a 2-PR split of #891. Stacked on #896.
What this PR does
Finishes the SemanticDB → SCIP migration on the Kotlin side, removes the now-unused SemanticDB consumer fallback and protobuf machinery, scrubs SemanticDB wording from docs, and applies four small simplifications that became possible once the legacy SemanticDB visitors were gone.
Pipeline before vs after this PR
Commits
10 commits:
semanticdb-kotlincemits only SCIP shards (dropsSemanticdbVisitor.kt/SemanticdbTextDocumentBuilder.kt/SemanticdbBuilders.ktand associated tests).ScipSemanticdb,SignatureFormatter,SemanticdbTreeVisitor, etc. — ~1.8 KLOC).semanticdb.protoin bothsemanticdb-javaandsemanticdb-kotlinc,SemanticdbBuilders.java, plus the now-unusedsemanticdb-javaprotobuf wiring inbuild.sbt).docs/,CONTRIBUTING.md,build.sbt, plus removing a danglingpipeline.svgreference and the now-obsolete "Why per-file SCIP shards?" section.ScipOccurrencesto a stateful accumulator (Java + Kotlin), drop the redundantScipRoleenum, inline one-call wrappers, prune dead helpers (e.g.MD5.java,TargetPaths.java, remnants of the oldCompilerRangeenum), andLinkedHashSet-ify relationship dedup.Net code change
~3,920 added / ~8,477 removed across ~105 files. Bulk is deletions (legacy SemanticDB output code, tests for that code, and the protobuf-driven
scip-semanticdbaggregator).Validation
sbt checkAll✅sbt unit/test✅ 28/28sbt minimized/{clean,compile}✅sbt snapshots/test✅ 23/23sbt semanticdbKotlincMinimized/clean kotlincSnapshots✅ (no snapshot drift)