Skip to content

Keep legacy selectors connected to current versions #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HawkSE wants to merge 3 commits into
base: main
Choose a base branch
from
+22 −12
Open

Keep legacy selectors connected to current versions #1849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aa7e6b
Keep legacy version manifests reachable
HawkSE Aug 31, 2026
5bc3b8b
Use Sourcegraph version manifest endpoint
HawkSE Sep 1, 2026
cefa763
Merge branch 'main' into hawkse/fix-legacy-current-version-manifest
HawkSE Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .agents/skills/publishing-docs-versions/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@ Use this skill for the Sourcegraph docs repo release-version workflow: cutting l
- `src/data/versions.ts`
- `docs/legacy.mdx`
- `src/data/versions.ts` on `origin/main` is the canonical dropdown list. The
current site exposes it through `/docs/api/versions`, and legacy selectors
load that manifest at runtime.
current site exposes it through `https://sourcegraph.com/docs/api/versions`,
and legacy selectors load that manifest at runtime.
- A legacy branch's bundled `src/data/versions.ts` is only a fallback. Its first
entry identifies the archived site and must not have the `latest` label.
- A legacy selector shows the current latest version, its selected archived
version, and older versions. It omits versions between latest and selected.

## Standard workflow for a new release

Expand Down
28 changes: 18 additions & 10 deletions src/components/VersionSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,23 @@ function isVersion(value: unknown): value is VersionI {
);
}

function versionsForSite(remoteVersions: VersionI[]): VersionI[] {
const selectedIndex = remoteVersions.findIndex(
version => version.name === versions[0].name
);

if (selectedIndex === 0) return remoteVersions;
if (selectedIndex > 0) {
return [remoteVersions[0], ...remoteVersions.slice(selectedIndex)];
}

return [
remoteVersions[0],
{...versions[0], label: undefined},
...versions.slice(1)
];
}

export default function VersionSelector() {
const path = usePathname();
const [availableVersions, setAvailableVersions] =
Expand Down Expand Up @@ -57,16 +74,7 @@ export default function VersionSelector() {
return;
}

setAvailableVersions(
remoteVersions.some(
version => version.name === versions[0].name
)
? remoteVersions
: [
...remoteVersions,
{...versions[0], label: undefined}
]
);
setAvailableVersions(versionsForSite(remoteVersions));
})
.catch(() => {
// Keep this build's version list if the current site is unavailable.
Expand Down