Keep legacy selectors connected to current versions - #1849
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a04534-2413-71c9-ac1f-51d83bd1fdbc Co-authored-by: Scott Ellison II <scott.ellison@sourcegraph.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| const versionsUrl = | ||
| process.env.NEXT_PUBLIC_DOCS_VERSIONS_URL ?? | ||
| 'https://sourcegraph.com/docs/api/versions'; | ||
| 'https://sourcegraph-docs-git-main-sourcegraph-f8c71130.vercel.app/docs/api/versions'; |
There was a problem hiding this comment.
hmm is this URL safe to use? Will it always point to main?
Can we see if the Security team has any advice on how to accomplish this? If we must, I think a better URL would be https://sourcegraph-docs-v2.vercel.app/docs as that seems to be static to our main deployment but I'd prefer if we kept this to sourcegraph.com domain
There was a problem hiding this comment.
I think the only way to get around this would be to add some sort of Cloudflare WAF exception for sourcegraph.com/docs/api/versions to keep this all in-tact.
There was a problem hiding this comment.
With the latest change to Cloudflare bot detection from the SEC team, this is no longer failing and the workaround is no longer needed. I've restored the Sourcegraph.com domain for this update.
Co-authored-by: Scott Ellison II <scott.ellison@sourcegraph.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a04534-2413-71c9-ac1f-51d83bd1fdbc
3 participants
Summary
mainVercel origin, avoiding Cloudflare challenges on cross-subdomain browser requestsTest plan
npx --yes pnpm@10.25.0 run build