Skip to content

Revamp config docs with helm-docs#50

Merged
michaellzc merged 1 commit into
mainfrom
02-25-Revamp_config_docs_with_helm-docs
Mar 2, 2022
Merged

Revamp config docs with helm-docs#50
michaellzc merged 1 commit into
mainfrom
02-25-Revamp_config_docs_with_helm-docs

Conversation

@michaellzc
Copy link
Copy Markdown
Member

@michaellzc michaellzc commented Feb 26, 2022

This PR added autogen docs based on values.yaml.

charts/<chart_name>/README.md should no longer be edited, and changes should be made in charts/<chart_name>/README.md.gotmpl

View the rendered version here

Test plan

Run ./scripts/helm-docs.sh, you should be able to generate the README.md

close https://github.com/sourcegraph/sourcegraph/issues/31016

@michaellzc
Copy link
Copy Markdown
Member Author

michaellzc commented Feb 26, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@michaellzc michaellzc marked this pull request as ready for review February 26, 2022 06:35
@michaellzc michaellzc force-pushed the 02-25-Revamp_config_docs_with_helm-docs branch 2 times, most recently from 52ce59b to f027f17 Compare February 26, 2022 19:01
@michaellzc michaellzc force-pushed the 02-25-Fix_securityContext_values_name branch from 754e93c to 54a8e10 Compare February 28, 2022 17:34
@michaellzc michaellzc force-pushed the 02-25-Revamp_config_docs_with_helm-docs branch from f027f17 to 80d32c7 Compare February 28, 2022 17:34
@michaellzc michaellzc force-pushed the 02-25-Fix_securityContext_values_name branch from 54a8e10 to 01d51e1 Compare February 28, 2022 17:37
@michaellzc michaellzc force-pushed the 02-25-Revamp_config_docs_with_helm-docs branch 2 times, most recently from 272c470 to c61fee9 Compare February 28, 2022 17:39
Base automatically changed from 02-25-Fix_securityContext_values_name to main February 28, 2022 18:38
@michaellzc michaellzc force-pushed the 02-25-Revamp_config_docs_with_helm-docs branch from c61fee9 to 3929944 Compare February 28, 2022 19:35
@michaellzc michaellzc force-pushed the 02-25-Revamp_config_docs_with_helm-docs branch from 3929944 to bdddee6 Compare March 1, 2022 05:38
Comment thread RELEASE.md Outdated
Comment thread charts/sourcegraph-migrator/values.yaml Outdated
Comment thread charts/sourcegraph-migrator/README.md.gotmpl Outdated
Comment thread charts/sourcegraph-migrator/README.md.gotmpl Outdated
Comment thread charts/sourcegraph-migrator/values.yaml Outdated
Comment thread charts/sourcegraph/values.yaml Outdated
Comment thread charts/sourcegraph/values.yaml
Comment thread charts/sourcegraph/values.yaml Outdated
Comment thread charts/sourcegraph/values.yaml
Comment thread charts/sourcegraph/values.yaml Outdated
@michaellzc michaellzc force-pushed the 02-25-Revamp_config_docs_with_helm-docs branch 2 times, most recently from 26210d7 to 1366f4b Compare March 1, 2022 21:55
@michaellzc michaellzc force-pushed the 02-25-Revamp_config_docs_with_helm-docs branch from 1366f4b to 09f629a Compare March 1, 2022 22:05
Copy link
Copy Markdown
Contributor

@caugustus-sourcegraph caugustus-sourcegraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for slogging through all this.

Side note - when you squash commits during an open review, it makes it hard for reviewers to tell what has changed since the PR was first opened. It's a faster and more reliable review cycle if fixes are kept as separate commits until the PR is merged.

@michaellzc
Copy link
Copy Markdown
Member Author

Nice work! Thanks for slogging through all this.

Side note - when you squash commits during an open review, it makes it hard for reviewers to tell what has changed since the PR was first opened. It's a faster and more reliable review cycle if fixes are kept as separate commits until the PR is merged.

Good call out! I can imagine it's pretty hard to inspect the diff again for large PR like this.

@michaellzc
Copy link
Copy Markdown
Member Author

michaellzc commented Mar 2, 2022

Graphite Merge Job

Current status: ✅ Merged

This pull request was successfully merged as part of a stack.

This comment was auto-generated by Graphite.

Job Reference: yNqXdfNl9dvIL5h0XluD

@michaellzc michaellzc merged commit 8da42c5 into main Mar 2, 2022
@michaellzc michaellzc deleted the 02-25-Revamp_config_docs_with_helm-docs branch March 2, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autogen doc for helm charts

2 participants