Fix securityContext values name

[michaellzc]

We're currently using and

• podSecurityContext as container-level securityContext (the naming is misleading)
• securityContext as pod-level securityContext (okay, but we should be more explicit)

This PR

• renamed podSecurityContext to containerSecurityContext
• renamed securityContext to podSecurityContext

Test plan

The test plan is to diff the output of rendered manifest, no change is expected.

kind create cluster

Revert to main

 git checkout HEAD~

helm upgrade --install -n sourcegraph --set storageClass.create=false,storageClass.name=standard,sourcegraph.localDevMode=true sourcegraph charts/sourcegraph/.

git checkout 02-25-Fix_securityContext_values_name

helm diff -n sourcegraph --set storageClass.create=false,storageClass.name=standard,sourcegraph.localDevMode=true sourcegraph charts/sourcegraph/.

There should be no difference.

close https://github.com/sourcegraph/sourcegraph/issues/31888

[michaellzc]

Current dependencies on/for this PR:

• main
  • PR Fix securityContext values name #48 (this PR)
    • PR Revamp config docs with helm-docs #50

This comment was auto-generated by Graphite.

[caugustus-sourcegraph]

This is a breaking change, so it requires bumping the minor version on the chart version.

Now that we've started combining multiple changes into a single release, and now have a breaking change, I think we should start producing a changelog. Before, it wasn't very important because one commit == one release.

[michaellzc]

This is a breaking change, so it requires bumping the minor version on the chart version.

Now that we've started combining multiple changes into a single release, and now have a breaking change, I think we should start producing a changelog. Before, it wasn't very important because one commit == one release.

@caugustus-sourcegraph

Added a changelog to record breaking changes. Also, I added a note to this the RELEASE.md https://github.com/sourcegraph/deploy-sourcegraph-helm/pull/50/files#diff-2b1b69303b927a484e02c7fad9fc87d0d3ff0dc22ae1da0ecd0dc935d922a23cR7 to keep an eye for breaking changes during release. Assuming we're fine with my proposed release process (multiple commits in one release instead of bumping the chart.yaml in every single commit)