Repository navigation
Generate restJson1 clients - #974
Open
stobrien89 wants to merge 1 commit into
Open
stobrien89 wants to merge 1 commit into
stobrien89 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Stacked on #973.
Description of changes:
Python clients now support
aws.protocols#restJson1, matching Java'sRestJsonIntegration:smithy_python.aws.AWS_PROTOCOLSadds restJson1 to the core protocols. Clients useRestJsonClientProtocolandAsyncRestJsonClientProtocolfromsmithy-aws-core[json]. The CLI uses this registry.ClientPlan.from_modeltakes the protocol IDs whose traits the service schema keeps.New
rest-json-1-clientsnapshot. It omits the 10 streaming operations, which client generation doesn't support yet, through a newomitOperationsprojection setting. 236 of the 244 vectors run (the other 8 belong to the omitted operations). The vector harness now checks host, query params, and list headers, and it handles AWS configs, documents, idempotency tokens and placeholder inputs.Strict xfails: the 7 vectors Java also skips (input defaults,
httpChecksumRequired, request compression), plus theRestJsonHttpPayloadTraitsWithNoBlobBodyresponse. For that one, the runtime reads an empty blob payload asb""instead of unset.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.