Skip to content

Generate restXml clients - #976

Open
stobrien89 wants to merge 1 commit into
python-client-aws-jsonfrom
python-client-rest-xml
Open

stobrien89 wants to merge 1 commit into
python-client-aws-jsonfrom
python-client-rest-xml

Conversation

@stobrien89

Copy link
Copy Markdown
Contributor

Issue #, if available:

Stacked on #975.

Description of changes:

Python clients now support aws.protocols#restXml, matching Java's RestXmlProtocolGenerator:

  • AWS_PROTOCOLS adds RestXmlClientProtocol and its async version from smithy-aws-core[xml].
  • ProtocolSettings now carries the service's xmlNamespace URI, which restXml applies to payloads that don't declare their own.
  • Schemas keep aws.customizations#s3UnwrappedXmlOutput, like Java's SchemaTraitFilterIndex.

New snapshots: rest-xml-client and rest-xml-with-namespace-client. All 180 vectors run, the same counts as the Java clients (178 and 2).

Harness changes:

  • XML bodies are compared parsed with xml_equal.
  • refresh_models.py now keeps model key order in vector files. XML sends map entries in order, so sorted keys broke the map cases. This rewrites the existing vector files but changes no cases.

Strict xfails: the 2 request compression cases Java skips, plus the HttpPayloadTraitsWithNoBlobBody response (the same empty blob gap as restJson in #974).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant