Repository navigation
Generate restXml clients - #976
Open
stobrien89 wants to merge 1 commit into
Open
stobrien89 wants to merge 1 commit into
stobrien89 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Stacked on #975.
Description of changes:
Python clients now support
aws.protocols#restXml, matching Java'sRestXmlProtocolGenerator:AWS_PROTOCOLSaddsRestXmlClientProtocoland its async version fromsmithy-aws-core[xml].ProtocolSettingsnow carries the service'sxmlNamespaceURI, which restXml applies to payloads that don't declare their own.aws.customizations#s3UnwrappedXmlOutput, like Java'sSchemaTraitFilterIndex.New snapshots:
rest-xml-clientandrest-xml-with-namespace-client. All 180 vectors run, the same counts as the Java clients (178 and 2).Harness changes:
xml_equal.refresh_models.pynow keeps model key order in vector files. XML sends map entries in order, so sorted keys broke the map cases. This rewrites the existing vector files but changes no cases.Strict xfails: the 2 request compression cases Java skips, plus the
HttpPayloadTraitsWithNoBlobBodyresponse (the same empty blob gap as restJson in #974).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.