Repository navigation
Resolve AWS endpoints with the AWS rules extension - #973
Open
stobrien89 wants to merge 1 commit into
Open
stobrien89 wants to merge 1 commit into
stobrien89 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Stacked on #971.
Description of changes:
AWS endpoint rules now work in Python clients, matching Java's
AwsEndpointRulesIntegration:BddEndpointResolver(BDD, extensions=[AWS_RULES_EXTENSION])for AWS services and for any service whose rules useaws.*functions orAWS::*built-ins. Generation no longer rejectsaws.partition,aws.parseArnandaws.isVirtualHostableS3Bucket.use_fips_endpoint,use_dualstack_endpointandaccount_id_endpoint_modewhen their rules declare those built-ins, resolved from the environment and profile.New
ClientIntegrationhooks:rules_extensionsandendpoint_test_builtin.The
features-clientfixture now usesaws.partition,AWS::UseFIPSand an endpoint auth scheme. Its 17 generated endpoint tests all pass with none skipped, the same cases Java generates. All 435 AWS models now plan their endpoints.S3 bucket and S3 Control account ID host prefix handling come with S3 support.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.