Repository navigation
Generate SigV4 auth for AWS Python clients - #971
Open
stobrien89 wants to merge 2 commits into
Open
stobrien89 wants to merge 2 commits into
stobrien89 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Stacked on #967.
Description of changes:
AWS services with
aws.auth#sigv4now get SigV4 auth, matching Java:auth_schemestoSigV4AuthScheme/AsyncSigV4AuthSchemefor the signing name. The credential fields already come fromAwsConfig._post_setupsets the default AWS credentials chain, using the config's profile, region and transport.Fixes a planning bug:
aws.auth#sigv4was only counted as an auth scheme if its trait definition was in the AST. AWS model ASTs leave it out, so every operation fell back tonoAuthand would have been generated unsigned.Adds
auth_schemes,write_client_methodsandendpoint_test_confighooks toClientIntegration.The per-feature snapshots (
endpoint-rules-client,api-key-auth-client,aws-config-client) are folded into onefeatures-client. It's a single AWS service built frommodels/features.smithy, with endpoint rules and tests, SigV4, API key auth,@optionalAuthand@auth([]).S3 signing properties come with S3 support.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.