Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions packages/smithy-aws-core/tests/unit/aio/test_protocols.py
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,47 @@ async def test_rest_xml_output_without_the_trait_reads_a_child_element() -> None
assert bare.location_constraint is None


@dataclass(kw_only=True)
class _NotRetrySafeError(ModeledError):
is_retry_safe: bool | None = False

@classmethod
def deserialize(cls, deserializer: Any) -> "_NotRetrySafeError":
return cls("not retry safe")


@pytest.mark.parametrize(
"status, error_shape, expected",
[
(500, _NoSuchBucket, True),
(404, _NoSuchBucket, None),
(503, _NotRetrySafeError, False),
],
)
async def test_rest_xml_modeled_error_retry_safety(
status: int,
error_shape: type[_NoSuchBucket | _NotRetrySafeError],
expected: bool | None,
) -> None:
with pytest.raises(error_shape) as exc_info:
await _deserialize_response(
_rest_xml_protocol(),
operation=_rest_xml_operation(),
request=cast(HTTPRequest, Mock()),
response=HTTPResponse(
status=status,
fields=tuples_to_fields([]),
body=b"<Error><Code>NoSuchBucket</Code></Error>",
),
error_registry=TypeRegistry(
{ShapeID("com.test#NoSuchBucket"): error_shape}
),
context=TypedProperties(),
)

assert exc_info.value.is_retry_safe is expected


_STATS_SCHEMA = Schema.collection(
id=ShapeID("com.test#Stats"),
members={"BytesScanned": {"target": INTEGER}},
Expand Down
90 changes: 90 additions & 0 deletions packages/smithy-http/tests/unit/test_protocols.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
# SPDX-License-Identifier: Apache-2.0

from dataclasses import dataclass
from typing import Any, Self

import pytest
Expand All @@ -9,6 +10,7 @@
from smithy_core.deserializers import ShapeDeserializer
from smithy_core.documents import TypeRegistry
from smithy_core.endpoints import Endpoint
from smithy_core.exceptions import CallError, ModeledError
from smithy_core.interfaces import TypedProperties as TypedPropertiesInterface
from smithy_core.interfaces import URI as URIInterface
from smithy_core.program import Program, run_program
Expand All @@ -20,6 +22,7 @@
from smithy_http import Field, Fields, HTTPRequest, HTTPResponse
from smithy_http.interfaces import HTTPErrorIdentifier
from smithy_http.interfaces import HTTPRequest as HTTPRequestInterface
from smithy_http.interfaces import HTTPResponse as HTTPResponseInterface
from smithy_http.protocols import HttpBindingClientProtocol, HttpClientProtocol
from smithy_json import JSONCodec

Expand Down Expand Up @@ -362,3 +365,90 @@ def test_extract_response_metadata_reports_only_the_status_code() -> None:
assert metadata.http_status_code == 429
assert metadata.request_id is None
assert metadata.extended_request_id is None


_MODELED_ERROR_ID = ShapeID("ns.foo#ModeledError")


class _ModeledErrorIdentifier(HTTPErrorIdentifier):
def identify(
self,
*,
operation: APIOperation[Any, Any],
response: HTTPResponseInterface,
) -> ShapeID | None:
return _MODELED_ERROR_ID


class _ModeledErrorProtocol(MockBindingProtocol):
_error_identifier = _ModeledErrorIdentifier()


class _ModeledError(ModeledError):
@classmethod
def deserialize(cls, deserializer: ShapeDeserializer) -> Self:
return cls("modeled error")


@dataclass(kw_only=True)
class _NotRetrySafeError(ModeledError):
is_retry_safe: bool | None = False

@classmethod
def deserialize(cls, deserializer: ShapeDeserializer) -> Self:
return cls("not retry safe")


def _deserialize_error(
protocol: HttpBindingClientProtocol, status: int, error_registry: TypeRegistry
) -> CallError:
operation: APIOperation[Any, Any] = APIOperation(
static_schema=(
ShapeType.OPERATION.value,
"ns.foo",
"FailingOperation",
{"smithy.api#http": {"method": "GET", "code": 200, "uri": "/"}},
LegacyInput.SCHEMA,
MockOutput.SCHEMA,
(),
),
model_registry=_STUB_REGISTRY,
effective_auth_schemes=[],
)
with pytest.raises(CallError) as exc_info:
run_program(
protocol.deserialize_response_program(
operation=operation,
request=HTTPRequest(
destination=URI(host="example.com"),
method="GET",
fields=Fields(),
),
response=HTTPResponse(body=b"", status=status, fields=Fields()),
error_registry=error_registry,
context=TypedProperties(),
read_body=lambda body: body,
)
)
return exc_info.value


@pytest.mark.parametrize(
"status, error_shape, expected",
[
(500, _ModeledError, True),
(400, _ModeledError, None),
(503, _NotRetrySafeError, False),
],
)
def test_http_binding_modeled_error_retry_safety(
status: int,
error_shape: type[_ModeledError | _NotRetrySafeError],
expected: bool | None,
) -> None:
error = _deserialize_error(
_ModeledErrorProtocol(), status, TypeRegistry({_MODELED_ERROR_ID: error_shape})
)

assert isinstance(error, error_shape)
assert error.is_retry_safe is expected
Loading