Repository navigation
Test retry classification of modeled HTTP binding errors - #969
Merged
Merged
Conversation
Cover a modeled error through HttpBindingClientProtocol and through RestXmlClientProtocol. The modeled-error cases in test_retry_classification.py leave restJson1 and restXml out.
AlexDaines
force-pushed
the
adaines/retry-modeled-error-tests
branch
from
November 20, 2026 00:07
f54700c to
ea4fe56
Compare
AlexDaines
marked this pull request as ready for review
November 20, 2026 01:30
arandito
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Two tests for #955, no source changes. The modeled-error cases in
test_retry_classification.pyleave restJson1 and restXml out (_UNBOUND_CASES), so no unit test covers the retry classification of a modeled error throughHttpBindingClientProtocol._create_errororRestXmlClientProtocol._create_error.I removed the
_classify_error_for_retrycall from each method in turn. The existing unit tests gave the same results, and each new test failed on its 500 case.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.