Skip to content

Test retry classification of modeled HTTP binding errors - #969

Merged
AlexDaines merged 1 commit into
developfrom
adaines/retry-modeled-error-tests
Nov 20, 2026
Merged

AlexDaines merged 1 commit into
developfrom
adaines/retry-modeled-error-tests

Conversation

@AlexDaines

Copy link
Copy Markdown
Collaborator

Issue #, if available: N/A

Description of changes:

Two tests for #955, no source changes. The modeled-error cases in test_retry_classification.py leave restJson1 and restXml out (_UNBOUND_CASES), so no unit test covers the retry classification of a modeled error through HttpBindingClientProtocol._create_error or RestXmlClientProtocol._create_error.

I removed the _classify_error_for_retry call from each method in turn. The existing unit tests gave the same results, and each new test failed on its 500 case.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Cover a modeled error through HttpBindingClientProtocol and through
RestXmlClientProtocol. The modeled-error cases in
test_retry_classification.py leave restJson1 and restXml out.
@AlexDaines
AlexDaines changed the base branch from retry-known-errors to develop November 20, 2026 00:07
@AlexDaines
AlexDaines force-pushed the adaines/retry-modeled-error-tests branch from f54700c to ea4fe56 Compare November 20, 2026 00:07
@AlexDaines
AlexDaines marked this pull request as ready for review November 20, 2026 01:30
@AlexDaines
AlexDaines requested a review from a team as a code owner November 20, 2026 01:30
@AlexDaines
AlexDaines merged commit 888dd66 into develop Nov 20, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants