Skip to content

fix(semgrep): add the push trigger to the README caller example #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twistedmelonman merged 2 commits into from
Oct 22, 2026
Merged

fix(semgrep): add the push trigger to the README caller example #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
000c473
fix(semgrep): add the push trigger to the README caller example
Oct 22, 2026
dd335f3
test(semgrep): skip comment lines in the README trigger extraction
Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,8 @@ name: Semgrep Scan
on:
pull_request:
workflow_dispatch:
push:
branches: [main]
permissions:
contents: read
jobs:
Expand Down
11 changes: 11 additions & 0 deletions tests/test-semgrep-scan.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,5 +111,16 @@ else
_bad "caller stub names changed"
fi

# 10. the README setup example has the stub's triggers
stub_on="$(awk '/^on:$/{f=1} /^permissions:$/{f=0} f && !/^ *#/' "${stub_file}")"
readme_on="$(awk '/^## `semgrep-scan.yml`$/{m=1} m && /^### Setup$/{s=1}
s && /^```yaml$/{y=1; next} y && /^```$/{exit}
y && /^on:$/{f=1} y && /^permissions:$/{f=0} f && !/^ *#/' "${readme}")"
if [[ -n "${stub_on}" && "${stub_on}" == *"push:"* && "${stub_on}" == "${readme_on}" ]]; then
_ok "README setup example has the caller stub's triggers"
else
_bad "trigger drift: stub='${stub_on}' README='${readme_on}'"
fi

echo "${pass} passed, ${fail} failed"
[[ "${fail}" -eq 0 ]]
Loading