Repository navigation
fix(semgrep): add the push trigger to the README caller example - #200
Merged
Merged
Conversation
added 2 commits
October 21, 2026 19:45
The README setup example lacked the push-to-main trigger that semgrep/caller-stub.yml gained in #198. Add it, and a test that the example's triggers match the stub's. Advances smartwatermelon/dev-env#166.
Match the stub side, so a comment in the README example does not read as trigger drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
semgrep-scan.ymlsetup example lacked thepush: branches: [main]trigger thatsemgrep/caller-stub.ymlgained in feat(semgrep): add a reusable Semgrep CE scan workflow #198 (found by the feat(semgrep): add a reusable Semgrep CE scan workflow #198 pre-merge review).on:block must match the stub's.Advances smartwatermelon/dev-env#166.
Test plan
bash tests/test-semgrep-scan.sh: 17 pass. The new test failed against the old README before the fix.