Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sqlite_utils/db.py
Original file line number Diff line number Diff line change
Expand Up @@ -2003,6 +2003,8 @@ def rows_where(
if limit is not None:
sql += f" limit {limit}"
if offset is not None:
if limit is None:
sql += " limit -1"
sql += f" offset {offset}"
cursor = self.db.execute(sql, where_args or [])
columns = dedupe_keys(c[0] for c in cursor.description)
Expand Down Expand Up @@ -3594,6 +3596,8 @@ def search_sql(
if limit is not None:
limit_offset += f" limit {limit}"
if offset is not None:
if limit is None:
limit_offset += " limit -1"
limit_offset += f" offset {offset}"
return sql.format(
dbtable=quote_identifier(self.name),
Expand Down
7 changes: 7 additions & 0 deletions tests/test_rows.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ def test_rows_where_offset_limit(fresh_db, offset, limit, expected):
]


def test_rows_where_offset_without_limit(fresh_db):
table = fresh_db["rows"]
table.insert_all([{"id": id} for id in range(1, 6)], pk="id")
ids = [r["id"] for r in table.rows_where(offset=2, order_by="id")]
assert ids == [3, 4, 5]


def test_pks_and_rows_where_rowid(fresh_db):
table = fresh_db["rowid_table"]
table.insert_all({"number": i + 10} for i in range(3))
Expand Down
Loading