Fix rows_where() crash when offset is given without limit#817
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix rows_where() crash when offset is given without limit#817ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
SQLite requires LIMIT before OFFSET; omitting it raised OperationalError. When offset is set and limit is not, emit LIMIT -1 first so the SQL is valid. Same fix applied to search_sql(). Adds regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite requires a LIMIT clause before OFFSET; without one,
rows_where(offset=N)generatesSELECT … OFFSET Nwhich raisesOperationalError: near "N": syntax error. The fix emitsLIMIT -1automatically when offset is set but limit is not, which SQLite treats as "no upper bound". The same pattern is fixed insearch_sql(). A regression test is added. Fixes #816Generated by Claude Code
📚 Documentation preview 📚: https://sqlite-utils--817.org.readthedocs.build/en/817/