-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Stop shutdown handler outputting in child processes #6411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sebastianbergmann
merged 4 commits into
sebastianbergmann:12.4
from
kynx:shutdown-handler-with-child-process
Nov 21, 2025
+60
−2
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6be1c17
Add failing test for ShutdownHandler with child process
mattkynaston 0699696
ShutdownHandler does not output in child processes
mattkynaston 69022c7
Skip test if pcntl not available, remove require-dev
mattkynaston cbccb67
Remove unnecessary filter
mattkynaston File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <?php declare(strict_types=1); | ||
| /* | ||
| * This file is part of PHPUnit. | ||
| * | ||
| * (c) Sebastian Bergmann <sebastian@phpunit.de> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
| namespace PHPUnit\TestFixture; | ||
|
|
||
| use function pcntl_fork; | ||
| use function pcntl_wait; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| final class ChildProcessTest extends TestCase | ||
| { | ||
| public function testChildProcessOutput(): void | ||
| { | ||
| $child = pcntl_fork(); | ||
| $this->assertGreaterThan(-1, $child); | ||
|
|
||
| if ($child) { | ||
| pcntl_wait($child); | ||
| $this->assertTrue(true); | ||
| } else { | ||
| exit(0); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| --TEST-- | ||
| ShutdownHandler does not output when child process exits | ||
| --SKIPIF-- | ||
| <?php declare(strict_types=1); | ||
| if (!extension_loaded('pcntl')) { | ||
| print 'skip: Extension pcntl must be loaded.'; | ||
| } | ||
| --FILE-- | ||
sebastianbergmann marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <?php declare(strict_types=1); | ||
| $_SERVER['argv'][] = '--do-not-cache-result'; | ||
| $_SERVER['argv'][] = '--no-configuration'; | ||
| $_SERVER['argv'][] = __DIR__ . '/../_files/ChildProcessTest.php'; | ||
|
|
||
| require __DIR__ . '/../../bootstrap.php'; | ||
|
|
||
| (new PHPUnit\TextUI\Application)->run($_SERVER['argv']); | ||
| --EXPECTF-- | ||
| PHPUnit %s by Sebastian Bergmann and contributors. | ||
|
|
||
| Runtime: %s | ||
|
|
||
| . 1 / 1 (100%) | ||
|
|
||
| Time: %s, Memory: %s | ||
|
|
||
| OK (1 test, 2 assertions) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.