Skip to content

Conversation

@kynx
Copy link

@kynx kynx commented Nov 12, 2025

This fixes #6410

@kynx kynx changed the base branch from main to 12.5 November 12, 2025 22:10
@kynx kynx changed the base branch from 12.5 to 12.4 November 12, 2025 22:10
@sebastianbergmann
Copy link
Owner

@staabm Can you have a look at this? Thanks!

composer.json Outdated
},
"require-dev": {
"ext-pcntl": "*"
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer.lock needs to be updated after composer.json is changed. This is the reason why the CI pipeline failed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it as suggested in #6411 (comment)

Copy link
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks

@sebastianbergmann sebastianbergmann merged commit 4f2bc5d into sebastianbergmann:12.4 Nov 21, 2025
29 checks passed
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.89%. Comparing base (84b19c6) to head (cbccb67).
⚠️ Report is 48 commits behind head on 12.4.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Runner/ShutdownHandler.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               12.4    #6411   +/-   ##
=========================================
  Coverage     95.89%   95.89%           
- Complexity     7406     7407    +1     
=========================================
  Files           789      789           
  Lines         22600    22601    +1     
=========================================
+ Hits          21673    21674    +1     
  Misses          927      927           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann
Copy link
Owner

@kynx Thank you for working on this. In the future, please follow the contribution guidelines and configure your real name for your Git commits.

@staabm Thank you for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test runner's shutdown handler is called in system-under-test's child process

3 participants