-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Stop shutdown handler outputting in child processes #6411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop shutdown handler outputting in child processes #6411
Conversation
|
@staabm Can you have a look at this? Thanks! |
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "ext-pcntl": "*" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
composer.lock needs to be updated after composer.json is changed. This is the reason why the CI pipeline failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed it as suggested in #6411 (comment)
staabm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thanks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 12.4 #6411 +/- ##
=========================================
Coverage 95.89% 95.89%
- Complexity 7406 7407 +1
=========================================
Files 789 789
Lines 22600 22601 +1
=========================================
+ Hits 21673 21674 +1
Misses 927 927 ☔ View full report in Codecov by Sentry. |
|
@kynx Thank you for working on this. In the future, please follow the contribution guidelines and configure your real name for your Git commits. @staabm Thank you for reviewing! |
This fixes #6410