Skip to content

Raise ValueError on invalid scale in render_images #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtreis merged 1 commit into from
May 8, 2026
+6 −6
Merged

Raise ValueError on invalid scale in render_images #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/spatialdata_plot/pl/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3007,12 +3007,12 @@ def _validate_image_render_params(
element_params[el]["norm"] = norm
scale = param_dict["scale"]
if scale and isinstance(param_dict["sdata"][el], DataTree):
if scale not in list(param_dict["sdata"][el].keys()) and scale != "full":
element_params[el]["scale"] = None
else:
element_params[el]["scale"] = scale
else:
element_params[el]["scale"] = scale
valid_scales = list(param_dict["sdata"][el].keys())
if scale not in valid_scales and scale != "full":
raise ValueError(
f"Scale '{scale}' does not exist in image '{el}'. Valid scales: {valid_scales + ['full']}."
)
element_params[el]["scale"] = scale
element_params[el]["colorbar"] = param_dict["colorbar"]
element_params[el]["colorbar_params"] = param_dict["colorbar_params"]

Expand Down
Loading