Raise ValueError on invalid scale in render_images#654
Merged
Conversation
Previously, render_images(scale="...") silently reset an unknown scale name to None and auto-picked a resolution, discarding the user's intent without warning. The downstream _multiscale_to_spatial_image already had the right ValueError but was unreachable because the value was cleared beforehand. Validate at the entry point and surface the error with the list of valid scales. Closes #623
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
=======================================
Coverage 77.07% 77.07%
=======================================
Files 11 11
Lines 3276 3276
Branches 772 772
=======================================
Hits 2525 2525
Misses 453 453
Partials 298 298
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render_images(scale=...)silently reset unknown scale names toNoneand auto-picked a resolution, discarding the user's intent._multiscale_to_spatial_imagealready had the rightValueErrorbut was unreachable because_validate_image_render_paramscleared the value beforehand."full").Closes #623