Skip to content

CI: test MSRV on windows, too #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanna-kruppe wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CI: test MSRV on windows, too #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f717ed
fix MSRV in windows specific tests
hanna-kruppe Dec 19, 2025
183ef09
test MSRV on windows, too
hanna-kruppe Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,17 @@ jobs:
strategy:
fail-fast: false
matrix:
build: [stable, 1.70.0, beta, nightly, macos, windows]
build: [stable, msrv-linux, msrv-windows, beta, nightly, macos, windows]
include:
- build: stable
os: ubuntu-latest
rust: stable
- build: 1.70.0
- build: msrv-linux
Copy link
Author

@hanna-kruppe hanna-kruppe Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: I had to come up with a new value for build because using the same for both MSRV jobs means only one of them runs. The github UI on other PRs suggests that this job wasn't a "required check" even when it was called "Test (1.70.0)", but in case the MSRV check is intended to be required, someone will have to dig through the branch protection rules to make them required under the new names.

os: ubuntu-latest
rust: 1.70.0
- build: msrv-windows
os: windows-latest
rust: 1.70.0
- build: beta
os: ubuntu-latest
rust: beta
Expand Down
4 changes: 2 additions & 2 deletions tests/socket.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,9 +446,9 @@ where
socket.as_raw_socket() as _,
WinSock::SIO_GET_MULTIPLE_EXTENSION_FUNCTION_POINTER,
(&guid as *const GUID) as *const _,
size_of_val(&guid) as u32,
mem::size_of_val(&guid) as u32,
table.as_mut_ptr() as *mut _,
size_of_val(&table) as u32,
mem::size_of_val(&table) as u32,
(&mut bytes as *mut i32) as *mut _,
ptr::null_mut(),
None,
Expand Down