CI: test MSRV on windows, too #627
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanna-kruppe
force-pushed
the
ci/msrv-windows
branch
from
7815673 to
183ef09
Compare
hanna-kruppe
commented
Dec 19, 2025
| os: ubuntu-latest | ||
| rust: stable | ||
| - build: 1.70.0 | ||
| - build: msrv-linux |
Author
There was a problem hiding this comment.
NB: I had to come up with a new value for build because using the same for both MSRV jobs means only one of them runs. The github UI on other PRs suggests that this job wasn't a "required check" even when it was called "Test (1.70.0)", but in case the MSRV check is intended to be required, someone will have to dig through the branch protection rules to make them required under the new names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in #621 that this isn't tested