Move more `rustdoc-html` tests using `--test` into the right folder by GuillaumeGomez · Pull Request #162014 · rust-lang/rust

GuillaumeGomez · 2026-08-30T14:27:30Z

Follow-up of #161944.

I double-checked if more rustdoc-html tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).

Oh also second commit is me realizing that some ui tests were using compile-args (which doesn't exist anymore) and without @. Anyway, fixed that too.

r? @fmease

fmease

review of 1st commit

View changes since this review

fmease

Nice! Thanks a lot!

I wonder if we should at some point modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea

r=me once nits addressed

View changes since this review

fmease · 2026-08-30T14:39:46Z

+//@ compile-flags: --crate-type lib
+


Suggested change

//@ compile-flags: --crate-type lib

or remove it altogether since it's not really relevant (rustdoc doesn't look for main even if the crate type is bin)

Yeah actually I need to remove it.

GuillaumeGomez · 2026-08-30T14:51:38Z

I wonder if we should modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea

On it. ;)

I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).

fmease · 2026-08-30T16:49:01Z

@@ -1,5 +1,4 @@
 //@ check-pass
-// compile-args: --cap-lints=warn -Fwarnings


Wait, this should be converted to //@ compile-flags like you did before. This test specifically intended to test the interaction between --cap-lints=warn and -Fwarnings as the paragraph states below.

Or did that lead to a failure? If so we might want to open a GH issue & investigate further.

View changes since the review

fmease · 2026-08-30T16:51:23Z

Accidental removal while trying to apply #162014 (comment) (there's still the corresp. *.stderr file)?.

View changes since the review

GuillaumeGomez · 2026-08-31T14:07:12Z

@bors r=fmease rollup

rust-bors · 2026-08-31T14:07:16Z

📌 Commit 614d9ea has been approved by fmease

It is now in the queue for this repository.

rustbot · 2026-08-31T16:30:34Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rust-bors · 2026-08-31T16:30:35Z

⚠️ A new commit fa9cd5bd4c583c3b5311698485482ad514026c30 was pushed.

This pull request was unapproved.

rust-bors · 2026-09-01T03:16:46Z

This pull request was unapproved.

This PR was contained in a rollup (#162100), which was unapproved.

View changes since this unapproval

GuillaumeGomez · 2026-09-01T14:13:25Z

@bors r=fmease rollup

rust-bors · 2026-09-01T14:13:28Z

📌 Commit 92e4d2a has been approved by fmease

It is now in the queue for this repository.

GuillaumeGomez · 2026-09-01T14:13:53Z

@bors r-

rust-bors · 2026-09-01T14:13:58Z

This pull request was unapproved.

View changes since this unapproval

GuillaumeGomez · 2026-09-01T14:21:06Z

Now it's good.

@bors r=fmease rollup

rust-bors · 2026-09-01T14:21:09Z

📌 Commit 5ba810f has been approved by fmease

It is now in the queue for this repository.

@fmease

…ease Move more `rustdoc-html` tests using `--test` into the right folder Follow-up of rust-lang#161944. I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing). Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too. r? @fmease

@fmease

…ease Move more `rustdoc-html` tests using `--test` into the right folder Follow-up of rust-lang#161944. I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing). Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too. r? @fmease

JonathanBrouwer · 2026-09-01T19:25:42Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #162139 (comment)

rust-bors · 2026-09-01T19:25:51Z

This pull request was unapproved.

This PR was contained in a rollup (#162139), which was unapproved.

View changes since this unapproval

GuillaumeGomez · 2026-09-01T19:33:50Z

Arf, a test stdout was only generated on mac. Talk about bad luck. :')

@bors try jobs=aarch64-apple-1

Move more `rustdoc-html` tests using `--test` into the right folder try-job: aarch64-apple-1

rust-bors · 2026-09-01T21:49:18Z

☀️ Try build successful (CI)
Build commit: 0878440 (08784406009b5f42c6a6fe27bd3a37e454f83d55)
Base parent: a433023 (a4330234a776684c36428d001721d0320d24dd77)

rustbot assigned fmease Aug 30, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 30, 2026

fmease reviewed Aug 30, 2026

View reviewed changes

fmease approved these changes Aug 30, 2026

View reviewed changes

fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2026

GuillaumeGomez force-pushed the more-ui-tests branch from bd5786a to 8374270 Compare August 30, 2026 16:08

fmease reviewed Aug 30, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the more-ui-tests branch from 8374270 to fba1d54 Compare August 30, 2026 19:22

GuillaumeGomez mentioned this pull request Aug 30, 2026

Prevent --test to be used in rustdoc-html testsuite #162030

Open

This comment has been minimized.

Sign in to view

Move more rustdoc-html tests using --test into the right folder

41258df

GuillaumeGomez force-pushed the more-ui-tests branch from fba1d54 to 815bbce Compare August 31, 2026 09:47

This comment has been minimized.

Sign in to view

Fix invalid compile-args ui tests argument

614d9ea

GuillaumeGomez force-pushed the more-ui-tests branch from 815bbce to 614d9ea Compare August 31, 2026 12:27

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 31, 2026

GuillaumeGomez force-pushed the more-ui-tests branch from 614d9ea to fa9cd5b Compare August 31, 2026 16:30

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 31, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 31, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2026

Normalize more rustdoc-ui doctest output

5ba810f

GuillaumeGomez force-pushed the more-ui-tests branch from 92e4d2a to 5ba810f Compare September 1, 2026 14:20

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2026

JonathanBrouwer mentioned this pull request Sep 1, 2026

Rollup of 7 pull requests #162136

Closed

JonathanBrouwer mentioned this pull request Sep 1, 2026

Rollup of 11 pull requests #162139

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2026

Add missing rustdoc-ui test output

09db866

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 1, 2026

Auto merge of #162014 - GuillaumeGomez:more-ui-tests, r=<try>

0878440

Move more `rustdoc-html` tests using `--test` into the right folder try-job: aarch64-apple-1

		@@ -1,5 +1,4 @@
		//@ check-pass
		// compile-args: --cap-lints=warn -Fwarnings

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Aug 30, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fmease left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmease Aug 30, 2026

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Aug 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GuillaumeGomez commented Aug 30, 2026

Uh oh!

fmease Aug 30, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmease Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez commented Aug 31, 2026

Uh oh!

rust-bors Bot commented Aug 31, 2026

Uh oh!

rustbot commented Aug 31, 2026

Uh oh!

rust-bors Bot commented Aug 31, 2026

Uh oh!

rust-bors Bot commented Sep 1, 2026

Uh oh!

GuillaumeGomez commented Sep 1, 2026

Uh oh!

rust-bors Bot commented Sep 1, 2026

Uh oh!

GuillaumeGomez commented Sep 1, 2026

Uh oh!

rust-bors Bot commented Sep 1, 2026

Uh oh!

GuillaumeGomez commented Sep 1, 2026

Uh oh!

rust-bors Bot commented Sep 1, 2026

Uh oh!

JonathanBrouwer commented Sep 1, 2026

Uh oh!

rust-bors Bot commented Sep 1, 2026

Uh oh!

GuillaumeGomez commented Sep 1, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

GuillaumeGomez commented Aug 30, 2026 •

edited by rustbot

Loading

fmease left a comment •

edited by rustbot

Loading

fmease left a comment •

edited

Loading

fmease Aug 30, 2026 •

edited by rustbot

Loading

fmease Aug 30, 2026 •

edited

Loading