Prevent --test to be used in rustdoc-html testsuite - #162030
Open
GuillaumeGomez wants to merge 4 commits into
Open
Prevent --test to be used in rustdoc-html testsuite#162030GuillaumeGomez wants to merge 4 commits into
--test to be used in rustdoc-html testsuite#162030GuillaumeGomez wants to merge 4 commits into
Conversation
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-testsuite
fmease
added
S-blocked
fmease
approved these changes
Aug 30, 2026
Member
There was a problem hiding this comment.
r=me once unblocked
As I've mentioned in #162014 (review) rejecting tests w/o any HtmlDocCk directives instead (someday in the future) might even be more helpful.
| pub(super) fn run_rustdoc_html_test(&self) { | ||
| assert!(self.variant.revision.is_none(), "revisions not supported in this test suite"); | ||
|
|
||
| if self.props.compile_flags.iter().any(|s| s == "--test") { |
Member
There was a problem hiding this comment.
For onlookers: We already do this sort of thing in compiletest, i.e., going through the compile flags to forbid certain ones (see --edition for example).
| pub(super) fn run_rustdoc_html_test(&self) { | ||
| assert!(self.variant.revision.is_none(), "revisions not supported in this test suite"); | ||
|
|
||
| if self.props.compile_flags.iter().any(|s| s == "--test") { |
Member
There was a problem hiding this comment.
People can accidentally bypass this check by using //@ doc-flags (for the record, you shouldn't use it for flags that are also supported by rustc but, oh well, that won't stop anyone).
Anyways, doesn't really matter. Feel free to implement or ignore that.
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
forbid-test-rustdoc-html
branch
from
August 31, 2026 16:32
3588207 to
fa9cd5b
Compare
rustbot
added
the
T-rustdoc-frontend
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
forbid-test-rustdoc-html
branch
from
August 31, 2026 17:40
8a20a9c to
5c99f49
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
Author
|
Now we wait for #162014 to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised.
CI will fail until #162014 is merged though.
r? @fmease